Fix dotnet test Command Not Recognizing NUnit3TestAdapter#164
Merged
FreeAndNil merged 4 commits intoapache:Feature/111-Dropping-support-for-older-runtimesfrom Aug 5, 2024
Conversation
Move reference to NUnit3TestAdapter to ItemGroup without TargetFramework condition
FreeAndNil
changed the base branch from
master
to
Feature/111-Dropping-support-for-older-runtimes
Contributor
|
@mobilebilly Thank you very much for your contribution. |
…it3TestAdapter version to 4.5.0
Contributor
Author
|
@FreeAndNil , no problem. |
FreeAndNil
requested changes
Aug 4, 2024
Contributor
FreeAndNil
left a comment
FreeAndNil
left a comment
There was a problem hiding this comment.
Please adjust as proposed, then we can merge.
Set IsTestProject to true and clean up garbage from old project file.
Contributor
Author
|
@FreeAndNil, the additional change in the test project is done. thank you |
FreeAndNil
merged commit 60d4fbc
into
apache:Feature/111-Dropping-support-for-older-runtimes
FreeAndNil
added a commit
that referenced
this pull request
Aug 6, 2024
This was referenced Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #109
This fix addresses the issue where the dotnet test command cannot recognize the NUnit3TestAdapter in existing ItemGroup elements.
Changes Made:
Moved the reference to NUnit3TestAdapter to an ItemGroup without a TargetFramework condition.