Defer creation of locking model to ActivateOptions()#95
Merged
fluffynuts merged 2 commits intoapache:masterfrom Oct 24, 2022
Merged
Defer creation of locking model to ActivateOptions()#95fluffynuts merged 2 commits intoapache:masterfrom
fluffynuts merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@FreeAndNil most of the changes here are whitespace, except:
I'm not 100% sure we want to expand the package size with the pdbs, considering the audience size of log4net. I'm open to be convinced here though (personally, since I use Rider, I can decompile any external sources enough to debug with, so pdbs have been of limited value). Please revert all the other files so that the impact is kept smaller. |
bb48e8b to
702184c
Compare
Contributor
Author
|
Hi @fluffynuts, i've reverted all the spacing changes. Regards |
fluffynuts
approved these changes
Oct 24, 2022
This was referenced Aug 19, 2025
This was referenced Nov 11, 2025
This was referenced Jan 7, 2026
This was referenced Jan 27, 2026
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The creation of the locking model instance is now deferred to ActivateOptions() so that defaultLockingModelType has an effect.
@fluffynuts Could you please review?