Repository navigation
Conversation
State that the paste-ready find uses a fixed baseline and show how release-build.md supplies additional globs (RAT-style), so prose and command agree on where the exclude list comes from. Generated-by: Cursor Grok 4.5 Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
potiuk
left a comment
There was a problem hiding this comment.
LGTM — and this is a more valuable fix than "align the docs" suggests. The old wording wasn't merely ambiguous, it was inverted in a way that could have let a non-compliant source release pass its own pre-flight.
What was actually broken
Two documents disagreed about what the Binary-exclude list means:
projects/_template/release-build.mdasked the adopter to "list any binary content the source artefact must NOT contain", and its example listed*.class,*.jar— "Java compiled output never ships in source."skills/release-verify-rc/SKILL.md:462then said: "A file that appears in the binary-exclude list ofrelease-build.mdis a known-and-accepted binary; surface it asEXPECTED-BINARY."
So an adopter who followed the template's own example would have configured Step 6 to classify compiled Java as EXPECTED-BINARY — i.e. accepted — switching off the prohibition for precisely the files the template told them never to ship. An artefact containing .class/.jar would have come back PASS. In a skill whose job is to catch exactly that before a release vote, that's the failure mode worth fixing.
Splitting the section's two jobs — additional prohibited globs vs known-accepted exceptions — removes the inversion, and rewriting the template example so *.class/*.jar are no longer list entries removes the trap that led to it.
The other drift you caught
The baseline find in Step 6 already scanned *.pyc and __pycache__, but three places disagreed with it:
- the prose immediately below said "The default prohibited extensions are
.class,.jar,.so,.dylib,.dll,.exe" — silently dropping both; - both eval fixtures'
paste_recipeomitted them, so the fixtures contradicted the command the skill actually emits.
Making the baseline explicit and mandatory ("Do not drop baseline predicates when the Binary-exclude list is empty or only restates the baseline") is the right guard, given .pyc presence is the tell that an artefact was zipped from a working tree rather than exported from the tag — which the existing comment already explained well.
I checked the change is complete rather than partial: case-1, case-2, and output-spec.md are all updated, and those are the only step-6 fixtures carrying a paste_recipe.
Smaller observations
Neither blocking; both are follow-up material rather than anything to change here.
- The two purposes now share one flat list, distinguished only by trailing prose (
— additional prohibited glob/— known-accepted exception). An agent reading an adopter's file has to infer the category from free text. Given the bug being fixed was a semantic ambiguity in this exact section, two sub-headings (or a two-column table) would make the distinction mechanical rather than interpretive. Worth a follow-up once this lands. assets/vendor/**/*.min.jsisn'tfindsyntax. The instruction says to "translate each into a-nameor-pathpredicate", which is right, but**has no meaning tofind— the shaped form is-path '*/assets/vendor/*.min.js'(find's*already crosses/). One parenthetical showing that translation would save the next reader a wrong-but-plausible-path 'assets/vendor/**/*.min.js'.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md § Opening a pull request.
Summary
release-verify-rcStep 6 so prose and the emittedfindagree:the scan always uses a fixed baseline of prohibited patterns; read
release-build.md§ Binary-exclude list (same file Step 4 uses for RAT)and append any extra globs beyond that baseline before emitting the recipe.
projects/_template/release-build.mdandprojects/magpie/release-build.md(additional prohibited globs vsknown-accepted exceptions).
output-spec.mdto match.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
uv run --project tools/skill-and-tool-validator --group dev skill-and-tool-validatepassesPYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/release-verify-rc/step-6-binary-exclusion/(print mode; fixtures extract cleanly)prek run --fileson touched paths passes (includescheck-placeholders,lychee,skill-and-tool-validate)output-spec.mdupdated for fixed-baseline + additions wordingRFC-AI-0004 compliance
Linked issues
Closes #940