[MDEPLOY-308] Add parameter to lax project validation#39
Merged
Conversation
| * with "pom" packaging and some classified artifact attached (typical example is some assembly being packaged | ||
| * and attached with classifier). | ||
| * | ||
| * @since 3.1.1 |
slawekjaranowski
approved these changes
Mar 21, 2023
apeteri
reviewed
Nov 20, 2023
| + "a main file to the project but it has attachments. Change packaging to 'pom'."); | ||
| if (allowIncompleteProjects) { | ||
| getLog().warn(""); | ||
| getLog().warn("The packaging plugin for this project did not assign"); |
Contributor
There was a problem hiding this comment.
Hi @cstamas,
Since processProject also gets called from deployAllAtOnce, the wording "this project" is a bit ambiguous. In addition to that, if an exception is thrown in "deploy at once" mode, it will get attributed to the last project that is marked with a deployment state enum, which can also be misleading.
Is it possible to add the name of the method parameter project into the log and exceptions thrown from this mehod?
Member
Author
There was a problem hiding this comment.
Sure! Quality patches accepted.
|
Resolve #561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MDEPLOY-308