-
Notifications
You must be signed in to change notification settings - Fork 915
Update jgit from 7.0.0 to 7.2.0 #8383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
interesting, some versioning tests failed can reproduce locally |
|
Both these use |
i had the same suspicion, but I believe this is still the git default. My global settings don't change it either. |
|
It looks like that there are some changes with that method in 7.2 anyway, and it's deprecated although does call through to the recommended replacement. I guess the name resolution might have tightened up somehow?! Maybe eclipse-jgit/jgit@7b8ddc2 ??? |
|
using Ref ref = repository.findRef("master");
ReflogReader reflogReader = repository.getRefDatabase().getReflogReader(ref);
assertEquals("merge " + info.getRevision() + ": Fast-forward", reflogReader.getLastEntry().getComment());this would work too: repository.getReflogReader("refs/heads/master")it expects the full path now. |
- deprecation fixes - updated UpdateRefTest to use findRef() before calling getReflogReader() to avoid null. Method expects the full path now.
|
refreshing this PR so that I don't have to test two branches at the same time |
btw |
skipped bouncycastle since NB osgi failed to load it the last time I tried #7569
dep trees:
Details