Update LSP4J to 0.24.0 and Xtend/Xtext to 2.32.0

[dasTanmoy0096]

Update dependencies: bump LSP4J to 0.24.0 and Xtext to 2.32.0, replace deprecated API usages.
Further cleaned up some Tests to better conform to changes in newer versions of LSP4J.

Since #9098 kept failing due to incorrect email in commit header, I closed the previous PR and raised this one.

[dasTanmoy0096]

Just curious, what happens when all tests pass, I believe a review process happens?

[matthiasblaesing]

@dasTanmoy0096 the process is less formal. Commits need at least one NetBeans committer to merge. It is a judgement call to merge. The unittests give a first indicator, review of the changes and potentially testing give the second factor.

The process is not necessarily limited to a single reviewer. Depending on the scope of the changes secondary opinions can be requested or other people chime in based on their area of interest.

Please indicate how you tested the changes.

[matthiasblaesing]

The changes make sense to me. The typescript integration still works, so I assume the client changes are fine.

@MartinBalin could you please have a look at the lsp.server changes? These look sane to me, but I don't use the LSP, so someone from that area would be good to have a look.

[mbien]

I've put the dependencies into a pom to check the dependency tree for surprises and it should be fine I think. gson is in range and guava is is fine too. (although it wouldn't hurt to update them separately at some point; edit: #9114)

Details

    <dependencies>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.generator</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.jsonrpc</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.debug</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.jsonrpc.debug</artifactId>
            <version>0.24.0</version>
        </dependency>

        <dependency>
            <groupId>org.eclipse.xtend</groupId>
            <artifactId>org.eclipse.xtend.lib</artifactId>
            <version>2.32.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.xtend</groupId>
            <artifactId>org.eclipse.xtend.lib.macro</artifactId>
            <version>2.32.0</version>
        </dependency>

        <dependency>
            <groupId>org.eclipse.xtext</groupId>
            <artifactId>org.eclipse.xtext.xbase.lib</artifactId>
            <version>2.32.0</version>
        </dependency>
    </dependencies>

--- toolbox:0.15.0:tree (default-cli) @ mavenproject1 ---
dev.mbien:mavenproject1:jar:0.1-SNAPSHOT (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.generator:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:jar:0.24.0 [compile] (origin: central)
|  \- com.google.code.gson:gson:jar:2.13.2 [compile] (range '[2.9.1,3.0)') (origin: central)
|     \- com.google.errorprone:error_prone_annotations:jar:2.41.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.debug:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc.debug:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.xtend:org.eclipse.xtend.lib:jar:2.32.0 [compile] (origin: central)
+- org.eclipse.xtend:org.eclipse.xtend.lib.macro:jar:2.32.0 [compile] (origin: central)
\- org.eclipse.xtext:org.eclipse.xtext.xbase.lib:jar:2.32.0 [compile] (origin: central)
   \- com.google.guava:guava:jar:32.1.2-jre [compile] (origin: central,sonatype-snapshots)
      +- com.google.guava:failureaccess:jar:1.0.1 [compile] (origin: central,sonatype-snapshots)
      +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava [compile] (origin: central,sonatype-snapshots)
      +- com.google.code.findbugs:jsr305:jar:3.0.2 [compile] (origin: central,sonatype-snapshots)
      +- org.checkerframework:checker-qual:jar:3.33.0 [compile] (origin: central,sonatype-snapshots)
      \- com.google.j2objc:j2objc-annotations:jar:2.8 [compile] (origin: central,sonatype-snapshots)

[MartinBalin]

Hi, yes, looking into LSP, thank you for pinging me.

[sdedic]

LGTM, looking at the lsp server part. I've tested briefly vscode apache nbls extension built on top of this branch as well.

[matthiasblaesing]

With both server and client covered, lets get this in.

[matthiasblaesing]

@dasTanmoy0096 thanks for work
@sdedic thanks for review!