-
Notifications
You must be signed in to change notification settings - Fork 2.9k
NIFI-15417 Re-enabled TestFileSystemRepository to run on Windows. #10722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dan-s1, similar to the NAR Loader tests, I recommend refactoring the setup approach to set explicit NiFi Property values where needed, instead of running search and replace on the ./target directory.
|
It looks like there are some file ownership or locking issues to resolve on Windows: |
…nused isWindowsEnvironment method, disabled those tests which cannot be run on Windows and fixed the test which should run on Windows.
…ClaimTooShort on Windows.
|
@exceptionfactory I tried a few things for test |
exceptionfactory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted on the NAR Loader test, specific properties should be passed in a separate Map, instead of modifying file lines while loading. In order to avoid duplicative work, I recommend getting the NAR Loader test changes to completion, and then revisiting this PR after we have finalized the basic approach.
Summary
NIFI-15417
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation