Skip to content

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Jan 1, 2026

Summary

NIFI-15417

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, similar to the NAR Loader tests, I recommend refactoring the setup approach to set explicit NiFi Property values where needed, instead of running search and replace on the ./target directory.

@exceptionfactory
Copy link
Contributor

exceptionfactory commented Jan 2, 2026

It looks like there are some file ownership or locking issues to resolve on Windows:

TestFileSystemRepository.testContentNotFoundExceptionThrownIfResourceClaimTooShort:305 � ContentNotFound Could not find content for StandardContentClaim [resourceClaim=StandardResourceClaim[id=0.bin, container=default, section=0], offset=0, length=11]

TestFileSystemRepository.testReadWithContentArchived:646 � FileSystem C:\UsersRUNNER~1AppDataLocalTempjunit-5303510819711634938\content_repository\1\1767311371088-1: The process cannot access the file because it is being used by another process

TestFileSystemRepository.testReadWithNoContentArchived:671 � FileSystem C:\UsersRUNNER~1AppDataLocalTempjunit-11250672784716168877\content_repository\1\1767311405192-1: The process cannot access the file because it is being used by another process

…nused isWindowsEnvironment method, disabled those tests which cannot be run on Windows and fixed the test which should run on Windows.
@dan-s1
Copy link
Contributor Author

dan-s1 commented Jan 5, 2026

@exceptionfactory I tried a few things for test testContentNotFoundExceptionThrownIfResourceClaimTooShort but I could not get it working on Windows. I therefore finally disabled it with the reason
java.io.FileNotFoundException when there is an attempt to access file <temporary directory>\content_repository\0\archive\0.bin

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted on the NAR Loader test, specific properties should be passed in a separate Map, instead of modifying file lines while loading. In order to avoid duplicative work, I recommend getting the NAR Loader test changes to completion, and then revisiting this PR after we have finalized the basic approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants