Skip to content

Conversation

@mosermw
Copy link
Member

@mosermw mosermw commented Jan 5, 2026

Summary

NIFI-15426

  • updated NOTICE Copyrights to 2026
  • removed unused JSch dependency from nifi-registry

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@joewitt
Copy link
Contributor

joewitt commented Jan 5, 2026

The copyright changes are solid and wow I guess we've missed a bunch of typos over the years!

The jsch part... why was that dangling and/or how did you notice?

@mosermw
Copy link
Member Author

mosermw commented Jan 5, 2026

The jsch part... why was that dangling and/or how did you notice?

Howdy Joe! After NiFi switched to Mina SSHD, I looked for anything still using JSch while reviewing a recent release. I found that nifi-registry still had references to JSch, and made a TODO to come back and investigate. Turns out it's been dangling since Registry was merged into the NiFi codebase.

@joewitt
Copy link
Contributor

joewitt commented Jan 6, 2026

Ok cool. am not at my laptop now but will merge tomorrow if it hasnt already been. Thanks for doing this.

@pvillard31 pvillard31 closed this in 04846ca Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants