Repository navigation
drivertest/watchdog: tighten reset cause and timing validation - #3983
Open
bigcat-2026 wants to merge 1 commit into
Open
bigcat-2026 wants to merge 1 commit into
bigcat-2026 wants to merge 1 commit into
Conversation
bigcat-2026
force-pushed
the
port/watchdog-test-validation
branch
from
November 6, 2026 01:38
e85e597 to
1067622
Compare
Use a chip-specific expected reset cause (ESP32-S3 reports a core MWDT reset instead of the system RWDT reset), and validate the reported timeleft against the measured ping delay. Ported from open-vela/nuttx-apps#142. Signed-off-by: bigcat2026 <bigcat_2026@163.com>
bigcat-2026
force-pushed
the
port/watchdog-test-validation
branch
from
November 6, 2026 01:42
1067622 to
be39731
Compare
| #define WDG_DEFAULT_TIMEOUT 2000 | ||
| #define WDG_DEFAULT_TESTCASE 0 | ||
| #define WDG_DEFAULT_DEVIATION 20 | ||
| #ifdef CONFIG_ARCH_CHIP_ESP32S3 |
Contributor
There was a problem hiding this comment.
but why check the special chip in the common code
Contributor
Author
There was a problem hiding this comment.
This change is for the ESP32-S3
casaroli
reviewed
Nov 7, 2026
| #define WDG_DEFAULT_TIMEOUT 2000 | ||
| #define WDG_DEFAULT_TESTCASE 0 | ||
| #define WDG_DEFAULT_DEVIATION 20 | ||
| #ifdef CONFIG_ARCH_CHIP_ESP32S3 |
Contributor
There was a problem hiding this comment.
On upstream the ESP32-S3 branch is never built: only boards/arm/n32h7 and boards/arm/samv7 provide board_reset_cause(), so CONFIG_BOARDCTL_RESET_CAUSE does not link on ESP32-S3.
Fix: drop the chip check and let the caller give the expected reset cause, for example with a new command-line option next to -a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten the watchdog driver test validation, ported from
open-vela/nuttx-apps#142.
BOARDIOC_RESETCAUSE_CORE_MWDTreset, while other platforms reportBOARDIOC_RESETCAUSE_SYS_RWDT.timeleftis not greater than the configuredtimeout.
of the configured ping delay.
Change
testing/drivers/drivertest/drivertest_watchdog.c