Repository navigation
Conversation
CI runs both in QEMU with NTFC: mps2-an500:citest is a flat build and mps2-an500:citest_protected is a protected build (CONFIG_BUILD_PROTECTED=y), both for the Cortex-M7. CI builds the protected configurations, but it runs none of them. citest is mps2-an500:nsh and citest_protected is mps2-an500:knsh, with the programs that the NTFC cases use: ostest, hello, helloxx, pipe, getprime, heap and setlogmask, and the pipe driver. Both have full optimization and no scheduler info messages. citest has no profiling (PROFILE_ALL, PROFILE_MINI, SYSTEM_GPROF). For citest_protected, QEMU loads the kernel (nuttx) with -kernel and the user image (nuttx_user.elf) with the generic loader. NTFC finds the commands in the ELF file of elf_path. The NSH commands and the test programs are in the user image, thus elf_path is nuttx_user.elf. run.sh is the one of sabre-6quad:citest, with one change: it moves each NTFC result directory into the artifact directory, not the result directory itself. When testbuild.sh retries a configuration, the result directory of the first attempt is already there: "mv result" then fails, result/ stays in the tree, and the tree check fails the retry. session.json excludes Nuttx_System_Arch_Os_Stability, which runs the heap test 10 times (about 170 s). Nuttx_System_Mm_Integration runs the heap test one time. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Add a Configurations section with mps2-an500:citest and mps2-an500:citest_protected and the QEMU commands that load their images. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Exclude all lm3s6965-ek configurations from the arm-ti test list. mps2-an500:citest and mps2-an500:citest_protected replace them in CI. The pull request gives the reasons. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
acassis
approved these changes
Nov 17, 2026
xiaoxiang781216
approved these changes
Nov 17, 2026
|
|
||
| -eagle100:thttpd | ||
| -launchxl-cc1310:nsh | ||
| -,lm3s6965-ek:.+ |
Contributor
There was a problem hiding this comment.
should we remove the broken config directly instead?
Contributor
Author
There was a problem hiding this comment.
I think we should consider a cleanup follow-up PR
|
casaroli
marked this pull request as draft
November 18, 2026 00:37
casaroli
marked this pull request as ready for review
November 18, 2026 00:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends-on: /pull/21975
Summary
CI builds the protected configurations (
CONFIG_BUILD_PROTECTED=y), but it runs none of them in QEMU. This PR adds two configurations for the Cortex-M7 (ARMv7-M) that CI runs with NTFC, as it runssabre-6quad:citestandqemu-armv8a:citest:mps2-an500:citest(flat build) andmps2-an500:citest_protected(protected build).citestismps2-an500:nshandcitest_protectedismps2-an500:knsh, with the programs that the NTFC cases use:ostest,hello,helloxx,pipe,getprime,heap,setlogmaskand the pipe driver. Both have full optimization and no scheduler info messages.citesthas no profiling (PROFILE_ALL,PROFILE_MINI,SYSTEM_GPROF).For
citest_protected, QEMU loads the kernel (nuttx) with-kerneland the user image (nuttx_user.elf) with the generic loader (-device loader). NTFC finds the commands in the ELF file ofelf_path. In a protected build the NSH commands and the test programs are in the user image, thuself_pathisnuttx_user.elf. Withelf_path: './nuttx', NTFC selects 3 of the 933 cases; withnuttx_user.elfit selects 77.session.jsonexcludesNuttx_System_Arch_Os_Stabilityin both configurations. That module runs the heap test 10 times (about 170 s on this board).Nuttx_System_Mm_Integrationruns the heap test one time.run.shis the one ofsabre-6quad:citest, with one change: it moves each NTFC result directory into the artifact directory, not theresultdirectory itself. Whentestbuild.shretries a configuration, theresultdirectory of the first attempt is already in the artifact directory. Thenmv resultfails,result/stays in the tree, and the tree check fails the retry. All othercitestscripts have this problem.lm3s6965-ek breaks CI often. Since August 2024, 15 commits in
boards/arm/tiva/lm3s6965-ekonly make a configuration fit or link again, 11 of them since July 2026: 7e0db94, 76b58e4, 2afdcfb, 0a0af89, a83c844, 3f38ca2, 1987473, 31a74e3, 58f89fa, 796fb3c, 6feaf0e, cb6d987, d9d9d3f, f3b6cf8, 51da55d, and now #21962.Apart from these and tree-wide changes, the board got two commits since 2024: 1128f6b (make
qemu-protectedboot in QEMU, March 2026) and 9d60832 (enableNET_SOCKOPTSinqemu-protected).qemu-protectedagain stops at boot today.CI only builds it and never runs it:
lm3s6965-ek:qemu-protectedstops after the boot lettersABCDEFin QEMU and gives no NSH prompt, and its 128 KiB kernel flash fails PRs that do not change its code (for example #21942, x86_64 code only, fails withregion `kflash' overflowed by 8 bytes).TI lists the LM3S6965 as Not Recommended for New Designs and recommends TM4C devices for new designs: https://www.ti.com/product/LM3S6965
The new
mps2-an500:citest(flat) andmps2-an500:citest_protectedconfigurations cover the same ground and more: ARMv7-M (Cortex-M7), a flat and a protected build, 4 MB of flash and 8 MB of RAM for each side of the protected build, and CI runs NTFC on both in QEMU.The third commit removes
lm3s6965-ekfrom the CI build list:tools/ci/testlist/arm-ti.datgets the line-,lm3s6965-ek:.+, the same form as-,arty_a7:.+inrisc-v-04.dat. The two new configurations replace it. No other testlist, workflow or CI script builds or runslm3s6965-ek(grepoftools/ciand.github: onlyarm-ti.datthrough/arm/tiva, andCODEOWNERS).The second commit adds both configurations to the board documentation.
Impact
CI only. The
Linux (arm-other)job builds the two new configurations with no testlist change (/arm/mps/mps2*intools/ci/testlist/arm-other.dat), andtestbuild.sh -Rruns theirrun.sh.CI time added to the arm-other job (measured, see Testing): about 5.3 minutes for
citestand 4.6 minutes forcitest_protected.CI time removed from the arm-ti job: the 8
lm3s6965-ekconfigurations took 415 s of the 3112 s of configuration builds in the arm-ti job of a recent CI run (run 44042631731).The other tiva boards stay in the build (see Testing). No change to the kernel, to the board code or to other configurations.
Make build only. The CMake build of this board has no rule for the user image (
No SOURCES given to target: nuttx_user), the same asmps2-an500:knsh; CI builds the mps2 configurations with make.Testing
Runs as CI does them, on an x86_64 Linux host in the CI image
ghcr.io/apache/nuttx/apache-nuttx-ci-linux(podman, 4 CPUs):pip install ntfc==0.0.3,nuttx-ntfc-testingtagrelease-0.0.2, then./cibuild.sh -c -A -N -R -Son a testlist with one line (/arm/mps/mps2-an500/configs/<config>,CONFIG_ARM_TOOLCHAIN_GNU_EABI), on nuttx master with this branch and nuttx-apps master. Each run starts with an empty ccache.citestcitestcitest_protectedcitest_protectedostestgivesostest_main: Exiting with status 0in both builds; the flat build also runs the FPU test. The 7 skipped cases are the same as insabre-6quad:citest(ls -s,uname -v/-m/-i,mw,exec, mmleak). The normalize step (refresh.sh) passes.In one earlier run of
citest_protected(host load about 25), NTFC stopped withdevice boot timeoutbefore the first test, and the next two retries failed because of therun.shproblem above, with 60 passed and 0 failed in NTFC. The cause of the boot timeout is not known: 80 direct boots of the two images reachednsh>in less than 0.2 s, and 30 more NTFC runs ofcitest_protectedpassed.tools/testbuild.sh -p(list only) onarm-ti.dat, before and after the change: 74 configurations listed in both. Before: 3 skipped (eagle100:thttpd,launchxl-cc1310:nsh,tms570ls31x-usb-kit:nsh). After: 11 skipped, the same 3 and the 8lm3s6965-ekconfigurations (discover,nsh,nx,qemu-flat,qemu-kostest,qemu-nxflat,qemu-protected,tcpecho). No other line changes, so the other tiva boards (lm3s6432-s2e,lm3s8962-ek,ekk-lm3s9b96, ...) are still built.make savedefconfiggives the committeddefconfigfiles.tools/checkpatch.sh -c -u -m -gpasses on the three commits.