Fixed: Disable 'New Shipment For Ship Group' buttons for purchase orders that are not approved (OFBIZ-13337)#935
Merged
JacquesLeRoux merged 2 commits intoapache:trunkfrom Jan 12, 2026
Conversation
|
Contributor
|
Hi Anahita, It seems to me that it does more than expected. Also with the error: "ERROR: Sales Order Lines lookup failed." Is that intended? |
Contributor
Author
|
Hi Jacques, |
Contributor
|
Hi Anihita, Oops, my bad. Too lazy to create a non approved PO :/ |
Contributor
|
I let you handle the Jira... |
Contributor
Author
|
Done! Thanks for the review. |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jan 12, 2026
…ers that are not approved (OFBIZ-13337) (#935) Explanation: When a PO is created but not yet approved, the Order Details screen displays the “New Shipment For Ship Group” buttons, which allows shipments to be created prior to order approval. This PR fixes this behavior by hiding the buttons until the order has been approved. This is one of the issues reported in [Step-by-step workflow: purchase orders with multiple shipments and invoices](https://cwiki.apache.org/confluence/display/OFBENDUSER/Step-by-step+workflow%3A+purchase+orders+with+multiple+shipments+and+invoices)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: When a PO is created but not yet approved, the Order Details screen displays the “New Shipment For Ship Group” buttons, which allows shipments to be created prior to order approval. This PR fixes this behavior by hiding the buttons until the order has been approved.
This is one of the issues reported in Step-by-step workflow: purchase orders with multiple shipments and invoices