Skip to content

Comments

Fixed: Form fields are not properly populated with values from the context due to a regression introduced by commit 69697d1 (OFBiz-13331)#936

Merged
jacopoc merged 1 commit intoapache:trunkfrom
golja:fix_useRequestParameters_setting
Jan 14, 2026
Merged

Fixed: Form fields are not properly populated with values from the context due to a regression introduced by commit 69697d1 (OFBiz-13331)#936
jacopoc merged 1 commit intoapache:trunkfrom
golja:fix_useRequestParameters_setting

Conversation

@golja
Copy link
Contributor

@golja golja commented Jan 13, 2026

This commit restores the condition that determines whether request or context parameters are used to the behavior prior to commit 69697d1. It also implements the new useRequestParameters.<form_name> context attribute for ModelGrid forms, which was introduced in that commit.

…ntext due to a regression introduced by commit 69697d1 (OFBiz-13331)

This commit restores the condition that determines whether request or context parameters are used to the behavior prior to commit 69697d1. It also implements the new useRequestParameters.<form_name> context attribute for ModelGrid forms, which was introduced in that commit.
@sonarqubecloud
Copy link

@jacopoc
Copy link
Contributor

jacopoc commented Jan 13, 2026

I have verified this pull request: it looks good to me and it fixes a relevant regression.
In fact, since commit 69697d1, all the forms of OFBiz trunk are broken as you can see from the screenshot below in which the form fields are not populated with the data from the ProductStore record.

Considering the severity of the issue, I suggest to merge this pull request as soon as possible. I could do it but I'd like to wait for @nmalin to verify if the use case addressed by his commit 69697d1 and described in OFBIZ-13331 is properly supported by this pull request.

Screenshot 2026-01-13 at 22 46 22

@jacopoc jacopoc requested a review from nmalin January 13, 2026 21:56
@jacopoc jacopoc merged commit fc69e4c into apache:trunk Jan 14, 2026
7 checks passed
@jacopoc
Copy link
Contributor

jacopoc commented Jan 14, 2026

@nmalin I decided to merge the PR to restore the form functionality, which was currently broken on trunk and on our demo instance. You can now review your work on OFBIZ-13331 without any time pressure.

@golja golja deleted the fix_useRequestParameters_setting branch January 15, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants