Skip to content

Release management: improve releaseEmailTemplate task#4163

Merged
adutra merged 1 commit intoapache:mainfrom
adutra:cleanup-release-vote-files
Apr 13, 2026
Merged

Release management: improve releaseEmailTemplate task#4163
adutra merged 1 commit intoapache:mainfrom
adutra:cleanup-release-vote-files

Conversation

@adutra
Copy link
Copy Markdown
Contributor

@adutra adutra commented Apr 10, 2026

The releaseEmailTemplate Gradle task wrote vote email files into build/distributions/, which were then copied to the Apache dist dev SVN repository by the release workflow. The cleanup rm command never worked due to shell quoting preventing glob/brace expansion.

This change moves the email template output to build/email-templates/ so it is never swept up by the bulk cp of distribution artifacts.

It also harmonizes the vote email template across the Gradle task, the release workflow, and the manual release guide.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

snazy
snazy previously approved these changes Apr 10, 2026
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Apr 10, 2026
dimas-b
dimas-b previously approved these changes Apr 10, 2026
adnanhemani
adnanhemani previously approved these changes Apr 13, 2026
The `releaseEmailTemplate` Gradle task wrote vote email files into `build/distributions/`, which were then copied to the Apache dist dev SVN repository by the release workflow. The cleanup `rm` command never worked due to shell quoting preventing glob/brace expansion.

This change moves the email template output to `build/email-templates/` so it is never swept up by the bulk cp of distribution artifacts.

It also harmonizes the vote email template across the Gradle task, the release workflow, and the manual release guide.
@adutra adutra dismissed stale reviews from adnanhemani, dimas-b, and snazy via 15bfcd0 April 13, 2026 10:50
@adutra adutra force-pushed the cleanup-release-vote-files branch from 2b3b901 to 15bfcd0 Compare April 13, 2026 10:50
@adutra adutra merged commit a959607 into apache:main Apr 13, 2026
23 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Apr 13, 2026
@adutra adutra deleted the cleanup-release-vote-files branch April 13, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants