Skip to content

Fix LICENSE/NOTICE files in the spark plugin bundle jar#4182

Merged
flyrain merged 3 commits intoapache:mainfrom
jbonofre:spark-plugin-license-fix
Apr 13, 2026
Merged

Fix LICENSE/NOTICE files in the spark plugin bundle jar#4182
flyrain merged 3 commits intoapache:mainfrom
jbonofre:spark-plugin-license-fix

Conversation

@jbonofre
Copy link
Copy Markdown
Member

As mentioned during 1.4.0 release vote, the spark plugin bundle jar LICENSE file mentions some dependencies not actually bundle in the jar.
This PR cleans up these dependencies from the LICENSE file.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

dimas-b
dimas-b previously approved these changes Apr 13, 2026
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Apr 13, 2026
adutra
adutra previously approved these changes Apr 13, 2026
@jbonofre jbonofre dismissed stale reviews from adutra and dimas-b via a3d82fd April 13, 2026 15:04
@jbonofre jbonofre changed the title Fix LICENSE file in the spark plugin bundle jar Fix LICENSE/NOTICE files in the spark plugin bundle jar Apr 13, 2026
@jbonofre jbonofre requested review from adutra and dimas-b April 13, 2026 15:05
Copy link
Copy Markdown
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @jbonofre ! It would be nice to detect gaps with a CI. Created an issue #4186 for that.

@jbonofre jbonofre requested a review from adnanhemani April 13, 2026 17:16
@jbonofre
Copy link
Copy Markdown
Member Author

@flyrain fair point. Let me try to draft a proposal for the build.

@flyrain flyrain merged commit 4eb9e84 into apache:main Apr 13, 2026
20 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Apr 13, 2026
@adutra adutra deleted the spark-plugin-license-fix branch April 13, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants