[Issue 443] add context param in producer interceptor#613
[Issue 443] add context param in producer interceptor#613GPrabhudas wants to merge 7 commits intoapache:masterfrom
Conversation
cckellogg
left a comment
There was a problem hiding this comment.
This is a breaking api change so we may need to figure out if that is ok or figure out if backwards compatibility is needed.
|
The Logic LGTM +1, as @cckellogg said, maybe we can add a new API for this change, e.g: |
Adding a new function to the interface will still be a breaking change. Applications will have have to implement the new method and recompile. I think that's what we need to figure out. Do we need to support backward compatibility or is making a breaking api change ok for the next release. |
Yes, my mistake. It seems that adding context does have actual usage scenarios and can further improve the processing capabilities of the interceptor itself. If we want to add this feature without breaking backward compatibility, can we try to directly expose a new interface to the user in ProducerOptions? For exampels, in and introduce a new interface But it is not a very elegant way to achieve |
liangyuanpeng
left a comment
There was a problem hiding this comment.
IMO,I agree with making a breaking api change ok for the next release..
This PR address issue-443
Ability to add properties to message before sending using context param.
Modified the producer interceptor methods to accept
contextparameter.