client option to set DefaultMaxMessageSize#699
Open
zzzming wants to merge 1 commit intoapache:masterfrom
Open
Conversation
dferstay
reviewed
Jan 5, 2022
| maxConnectionsPerHost int32 | ||
| roundRobinCnt int32 | ||
| metrics *Metrics | ||
| defaultMaxMessageSize int |
Contributor
There was a problem hiding this comment.
Suggest making this an int32 to be consistent with the type of connection.defaultMaxMessageSize.
Member
|
Hello @zzzming , in In the original design, the value of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the broker sets maxMessageSize more than 5MB, the go client can still get error
message size exceeds MaxMessageSize. Upon some conditions, the broker is not communicate the max message size in CommandConnected.MaxMessageSize. This PR will allow the client to set a non-default (5MB) message size if the MaxMessageSize is not present from the control channel.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesIt exposes a new configuration parameter to allow the client set the mexMessageSize
Documentation