Skip to content

Fix ack/nack use closed consumer #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billowqiu wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fix ack/nack use closed consumer #852

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e616355
Fix closed connection leak
billowqiu Jan 21, 2022
b949459
Fix closed connection leak
billowqiu Jan 21, 2022
9e82fef
Merge branch 'master' of github.com:billowqiu/pulsar-client-go
billowqiu Jan 21, 2022
566623b
bugfix: runEventsLoop for reconnect early exit
billowqiu Feb 5, 2022
6a1b11b
[optimize] add log when reconnect
billowqiu Feb 5, 2022
936c819
Merge branch 'master' into master
billowqiu Feb 5, 2022
bb283a5
[Bugfix]fix panic
billowqiu Feb 5, 2022
1b62d2f
Merge branch 'master' of github.com:billowqiu/pulsar-client-go
billowqiu Feb 5, 2022
15d2b07
[Bugfix]remove log conn ID
billowqiu Feb 5, 2022
cca8635
[optimize]Distinguish failed create producer log
billowqiu Feb 7, 2022
89debdf
fix conflicts
billowqiu Apr 19, 2022
b8053cb
Merge branch 'apache-master'
billowqiu Apr 19, 2022
6c83c7a
Merge branch 'apache:master' into master
billowqiu Apr 21, 2022
9abd918
Merge branch 'apache:master' into master
billowqiu May 10, 2022
482c445
Merge branch 'apache:master' into master
jayxhj Jun 6, 2022
593cca5
Merge branch 'apache:master' into master
billowqiu Aug 8, 2022
3e68196
Merge branch 'apache:master' into master
billowqiu Sep 21, 2022
3862295
fix ack/nack use closed consumer
billowqiu Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions pulsar/consumer_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,9 @@ func (c *consumer) AckID(msgID MessageID) error {
}

if mid.consumer != nil {
return mid.Ack()
if pc, ok := (mid.consumer).(*partitionConsumer); ok && pc.getConsumerState() == consumerReady {
return mid.Ack()
Copy link
Copy Markdown
Member

@wolfstudy wolfstudy Oct 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @billowqiu work for this, can we abstract a sharing method to check if the consumer object is active?

}
}

return c.consumers[mid.partitionIdx].AckID(mid)
Expand Down Expand Up @@ -522,8 +524,10 @@ func (c *consumer) Nack(msg Message) {
}

if mid.consumer != nil {
mid.Nack()
return
if pc, ok := (mid.consumer).(*partitionConsumer); ok && pc.getConsumerState() == consumerReady {
mid.Nack()
return
}
}
c.consumers[mid.partitionIdx].NackMsg(msg)
return
Expand All @@ -539,8 +543,10 @@ func (c *consumer) NackID(msgID MessageID) {
}

if mid.consumer != nil {
mid.Nack()
return
if pc, ok := (mid.consumer).(*partitionConsumer); ok && pc.getConsumerState() == consumerReady {
mid.Nack()
return
}
}

c.consumers[mid.partitionIdx].NackID(mid)
Expand Down