Skip to content

fix: remove circular dep in admin svc, adjusts default superuser env flag name and default #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 2 commits into from
May 11, 2024
Merged

fix: remove circular dep in admin svc, adjusts default superuser env flag name and default #572

lhotari merged 2 commits into from
May 11, 2024

Conversation

@maranmaran
Copy link
Contributor

@maranmaran maranmaran commented May 10, 2024 •
edited
Loading

Motivation

Fixes ##567
Tiny adjustment on parent PR #565 to match convention on flag name and it's bool default

Modifications

  • Remove unused service ref in PulsarAdminServiceImpl causing circular ref.
  • Rename default.superuser.enable -> default.superuser.enabled to match the convention
  • Default default.superuser.enabled flag to false in application.properties, remove from code
  • Adjust log entry when default superuser flag is disabled

Verifying this change

  • Make sure that the change passes the ./gradlew build checks.

@maranmaran maranmaran changed the title fix: adjust env var name, default in application.properties vs code a… refactor: adjust env var name, default in application.properties vs code a… May 10, 2024
@maranmaran maranmaran changed the title refactor: adjust env var name, default in application.properties vs code a… refactor: adjust env var name and default val to follow convention May 10, 2024
@maranmaran maranmaran changed the title refactor: adjust env var name and default val to follow convention fix: remove circular dep in admin svc, adjusts default superuser env flag name and default May 10, 2024
maranmaran
maranmaran commented May 10, 2024
View reviewed changes
lhotari
lhotari approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit f302f45 into apache:master May 11, 2024
@liangyepianzhou liangyepianzhou added this to the 0.4.0 milestone Jan 10, 2025
liangyepianzhou pushed a commit that referenced this pull request Jan 12, 2025
@maranmaran
fix: remove circular dep in admin svc, adjusts default superuser env …
3a7e4dd 
…flag name and default (#572)

* fix: adjust env var name, default in application.properties vs code and redefine log

* fix: remove circular ref

(cherry picked from commit f302f45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maranmaran @lhotari @liangyepianzhou