Reader support seek from separate messageId/time#10348
Merged
codelipenghui merged 11 commits intoapache:masterfrom May 15, 2021
Merged
Reader support seek from separate messageId/time#10348codelipenghui merged 11 commits intoapache:masterfrom
codelipenghui merged 11 commits intoapache:masterfrom
Conversation
Member
|
/pulsarbot run-failure-checks |
codelipenghui
added
the
doc-required
codelipenghui
requested review from
codelipenghui,
eolivelli,
merlimat and
sijie
eolivelli
requested changes
Apr 28, 2021
Member
|
@315157973 thanks for your great work. Could you please help add docs accordingly? Then I can help review, thanks |
sijie
approved these changes
May 4, 2021
Member
|
@merlimat @codelipenghui Can you review this PR? |
Anonymitaet
reviewed
May 8, 2021
Member
Anonymitaet
left a comment
Anonymitaet
left a comment
There was a problem hiding this comment.
Thanks for adding docs. I’ve left some comments, please check and keep consistencies for all occurrences, thanks.
Besides, docs are added to Reader.java and Consumer.java, Producer.java needs to be updated?
Anonymitaet
added
doc
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
codelipenghui
approved these changes
May 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9301
Motivation
Currently in ReaderConfigurationData the API allow to ‘setStartMessageId’ only from single message ID and this apply to all consumers in the
MultiTopicsReaderImpl.Is it possible to add start message per partition / topic.
Modifications
Reader can seek by function
Verifying this change
1 For partitioned topic, we can seek by time/messageId for every partition
2 For non-partitioned topic, we can seek by function