[ISSUE #219] Support to enable tls through configuration file#347
Merged
vongosling merged 11 commits intoapache:masterfrom Sep 8, 2021
Merged
Conversation
merge from rocketmq spring
chore(pom):update rocket-spring samples version (apache#336)
rocketmq-spring-boot-samples
RongtongJin
reviewed
Feb 13, 2021
Contributor
RongtongJin
left a comment
There was a problem hiding this comment.
It seems that there is no need to add a separate sample.
…elete separate samples
Contributor
Author
|
I have removed. |
RongtongJin
approved these changes
Feb 15, 2021
Contributor
It would be better to remove it from other samples because this configuration item is not required and commonly used. |
Contributor
Author
|
Hi @RongtongJin ,do i need merge from the master branch to update the latest version ,then submit again ? for security reason our company really need this feature |
Contributor
Author
|
@RongtongJin 大佬这个还能merge 进去吗?或者需要同步一下master? |
|
There exists some codes conflicts, please resolve the codes conflicts in you local enviroments please firstly. @liuliuzo |
Contributor
Author
|
@zongtanghu conflicts has been solved thx for review |
Contributor
Author
|
@zongtanghu ,我们同一个应用在订阅不同ROCKETMQ集群的时候,跨中心的集群访问需要开启TLS,不跨中心的集群不需要使用TLS,是有这个需求的。 |
Member
vongosling
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support to enable tls through configuration file. This feature can enable:
Brief changelog
add enable tls option by spring placeholder in annotations
###add new tls logic code
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #219] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.