Skip to content

[Fix][Transform-V2] Fix multiTable SQL transform#10263

Merged
zhangshenghang merged 11 commits into
apache:devfrom
dybyte:fix/sql-transform-multi-table
Feb 4, 2026
Merged

[Fix][Transform-V2] Fix multiTable SQL transform#10263
zhangshenghang merged 11 commits into
apache:devfrom
dybyte:fix/sql-transform-multi-table

Conversation

@dybyte
Copy link
Copy Markdown
Contributor

@dybyte dybyte commented Jan 2, 2026

Purpose of this pull request

  • Resolve ClassCastException by separating IdentityMapTransform and IdentityFlatMapTransform
  • Fix test using incorrect config file that masked the issue
AbstractMultiCatalogTransform$IdentityTransform cannot be cast to org.apache.seatunnel.api.transform.SeaTunnelFlatMapTransform

Does this PR introduce any user-facing change?

No.

How was this patch tested?

TestSQL.testSQLTransformMultiTable()

Check list

@zhangshenghang
Copy link
Copy Markdown
Member

Overall, it looks great. Could you add some unit tests?

dybyte added 5 commits January 8, 2026 01:45
…l-transform-multi-table

# Conflicts:
#	seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/SQLMultiCatalogFlatMapTransformTest.java
@dybyte
Copy link
Copy Markdown
Contributor Author

dybyte commented Jan 7, 2026

@zhangshenghang Added unit tests. PTAL, thanks.

@dybyte dybyte requested a review from zhangshenghang January 23, 2026 04:50
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

Copy link
Copy Markdown
Member

@zhangshenghang zhangshenghang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangshenghang zhangshenghang merged commit 4830dd5 into apache:dev Feb 4, 2026
5 checks passed
@dybyte dybyte deleted the fix/sql-transform-multi-table branch February 4, 2026 16:40
davidzollo pushed a commit to davidzollo/seatunnel that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants