Skip to content

[CI] pre-commit: auto add license check for Java files#1807

Merged
jiayuasu merged 1 commit intoapache:masterfrom
jbampton:pre-commit-java-license-headers
Feb 12, 2025
Merged

[CI] pre-commit: auto add license check for Java files#1807
jiayuasu merged 1 commit intoapache:masterfrom
jbampton:pre-commit-java-license-headers

Conversation

@jbampton
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

Added another check/hook/test to our pre-commit framework. This hook will auto add a license header to Java files on git commit if they are missing the license. So far all Java files seem to have the correct license so this is just a check to stop regressions and keep the code base standardized. Small piece of automation to auto add missing license headers.

How was this patch tested?

Added the license hook and then ran pre-commit for all files. No Java files were modified. I did test by changing / modifying a Java license and it did fail the hook test locally for that file.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton jbampton self-assigned this Feb 12, 2025
@jbampton jbampton requested a review from jiayuasu as a code owner February 12, 2025 19:34
@github-actions github-actions bot added the root label Feb 12, 2025
@jiayuasu jiayuasu merged commit ae4b1c2 into apache:master Feb 12, 2025
4 checks passed
@jbampton jbampton deleted the pre-commit-java-license-headers branch February 12, 2025 22:11
Kontinuation added a commit to Kontinuation/sedona that referenced this pull request Jan 21, 2026
…#386)

* [DOCS] Run Python black on Markdown code blocks (apache#1797)

* [CI] pre-commit autoupdate; configure `bandit[toml]` dependency (apache#1799)

Under bandit settings it lists the additional dependency for toml files

https://bandit.readthedocs.io/en/latest/config.html#bandit-settings

* [DOCS] Fix spelling (apache#1800)

* [CI] pre-commit: auto add license headers to `.c` and `.h` files (apache#1802)

* [CI] Update asf.yml (apache#1803)

* Commit

* Add john too

* [DOCS] Add Pranav Toggi to the Committers list (apache#1806)

* .asf.yaml: remove committer jbampton from collaborators (apache#1805)

https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#assigning-the-github-triage-role-to-external-collaborators

"Projects may assign external (non-committer) collaborators the triage role for their repository."

* [DOCS] Improve Makefile by Using requirements-docs.txt for Documentation Dependencies (apache#1808)

* Update Makefile

* Create requirements-docs.txt

* Update Makefile

* Update Makefile

* Update Makefile

* [CI] pre-commit: auto add license check for Java files (apache#1807)

* [DOCS] Fix spelling (apache#1804)

* [DOCS] Add geojson docs (apache#1814)

* use dashes not underscores

* fix whitespace

* update based on pr comments

* [DOCS] Add Matomo to Sedona website (apache#1820)

* [DOC] Update ST_KNN documentation for left inner join support and inner kNN join details (apache#1821)

* [DOCS] Correct the document for ST_MakeValid (apache#1822)

* [DOCS] add geoparquet docs page (apache#1818)

* add geoparquet docs page

* use linter

* centralize content on geoparquet page

* lint file

---------

Co-authored-by: Jia Yu <jiayu@apache.org>

* [DOCS] add docs on csv files (apache#1824)

* [DOCS] add spatial joins (apache#1829)

* [DOCS] add spatial joins page

* add alt text to images

* update spatial joins based on pr comments

* Update docs/tutorial/concepts/spatial-joins.md

---------

Co-authored-by: Jia Yu <jiayu@wherobots.com>

* Add several frequent contributors (apache#1833)

* [SEDONA-714] Add geopandas to spark arrow conversion. (apache#1825)

* SEDONA-714 Add geopandas to spark arrow conversion.

* SEDONA-714 Add geopandas to spark arrow conversion.

* SEDONA-714 Add geopandas to spark arrow conversion.

* SEDONA-714 Add geopandas to spark arrow conversion.

* SEDONA-714 Add geopandas to spark arrow conversion.

* Update python/sedona/utils/geoarrow.py

Co-authored-by: Dewey Dunnington <dewey@wherobots.com>

* SEDONA-714 Add geopandas to spark arrow conversion.

* SEDONA-714 Add docs.

* SEDONA-714 Add docs.

---------

Co-authored-by: Dewey Dunnington <dewey@wherobots.com>

* [SEDONA-713] add OSM PBF reader (apache#1823)

* Add OSM PBF reader.

Add documentation.

Add documentation.

Add documentation.

Add documentation.

Add documentation.

SEDONA-713 moving to common.

* SEDONA-713 Add docs.

* SEDONA-713 Add docs.

* SEDONA-713 Add docs.

* SEDONA-714 Add docs.

* [DOCS] add geopackage docs (apache#1835)

* [DOCS] add shapefiles documentation page (apache#1837)

* build(deps): bump com.google.protobuf:protobuf-java in /shade-proto (apache#1834)

Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 4.28.0 to 4.28.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-java
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [SEDONA-717] Fix `dataframe_to_arrow()` for zero-row results (apache#1840)

* fix zero-row case

* typo

* fix lint

* [SEDONA-718] Auto Detect geometry column in GeoJSON writer (apache#1841)

* [SEDONA-719] Support reading Shapefile with Z/M ordinates (apache#1842)

* [DOCS] Fix lint issue

* Fix shade-proto pom file name

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
Co-authored-by: Max Base <MaxBaseCode@Gmail.Com>
Co-authored-by: Matthew Powers <matthewkevinpowers@gmail.com>
Co-authored-by: Feng Zhang <feng@wherobots.com>
Co-authored-by: ruanqizhen <ruanqizhen@gmail.com>
Co-authored-by: Paweł Tokaj <pawel93kocinski@gmail.com>
Co-authored-by: Dewey Dunnington <dewey@wherobots.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kristin Cowalcijk <kontinuation@apache.org>
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants