Skip to content

Fix typos in URLParser. #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 1 commit into from
May 6, 2024
Merged

Fix typos in URLParser. #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Release Notes.
* Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin.
* Support for C3P0 connection pool tracing.
* Use a daemon thread to flush logs.
* Fix typos in `URLParser`.

All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/213?closed=1)

Expand Down
12 changes: 6 additions & 6 deletions ...s/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/URLParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ public class URLParser {
private static final String MARIADB_JDBC_URL_PREFIX = "jdbc:mariadb";
private static final String MSSQL_JTDS_URL_PREFIX = "jdbc:jtds:sqlserver:";
private static final String MSSQL_JDBC_URL_PREFIX = "jdbc:sqlserver:";
private static final String KYLIN_JDBC_URK_PREFIX = "jdbc:kylin";
private static final String IMPALA_JDBC_URK_PREFIX = "jdbc:impala";
private static final String CLICKHOUSE_JDBC_URK_PREFIX = "jdbc:clickhouse";
private static final String KYLIN_JDBC_URL_PREFIX = "jdbc:kylin";
private static final String IMPALA_JDBC_URL_PREFIX = "jdbc:impala";
private static final String CLICKHOUSE_JDBC_URL_PREFIX = "jdbc:clickhouse";

public static ConnectionInfo parser(String url) {
ConnectionURLParser parser = null;
Expand All @@ -54,11 +54,11 @@ public static ConnectionInfo parser(String url) {
parser = new MssqlJtdsURLParser(url);
} else if (lowerCaseUrl.startsWith(MSSQL_JDBC_URL_PREFIX)) {
parser = new MssqlJdbcURLParser(url);
} else if (lowerCaseUrl.startsWith(KYLIN_JDBC_URK_PREFIX)) {
} else if (lowerCaseUrl.startsWith(KYLIN_JDBC_URL_PREFIX)) {
parser = new KylinJdbcURLParser(url);
} else if (lowerCaseUrl.startsWith(IMPALA_JDBC_URK_PREFIX)) {
} else if (lowerCaseUrl.startsWith(IMPALA_JDBC_URL_PREFIX)) {
parser = new ImpalaJdbcURLParser(url);
} else if (lowerCaseUrl.startsWith(CLICKHOUSE_JDBC_URK_PREFIX)) {
} else if (lowerCaseUrl.startsWith(CLICKHOUSE_JDBC_URL_PREFIX)) {
parser = new ClickHouseURLParser(url);
}
return parser.parse();
Expand Down