-
Notifications
You must be signed in to change notification settings - Fork 668
Add a plugin that supports the Solon framework. #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
be675c2
Feat: Add a plugin that supports the Solon framework.
xsShuang 06732e8
Update ComponentsDefine.java
xsShuang 924c61f
Add Solon plugin test
xsShuang ffd56db
Merge remote-tracking branch 'origin/main'
xsShuang dbd24b4
Add Solon plugin test
xsShuang 0b2afff
Add Solon plugin test and update doc.
xsShuang b96e8c5
Merge remote-tracking branch 'origin/main'
xsShuang 88ef3ca
merge the latest commits.
xsShuang 0716d24
Modify the test code.
xsShuang 1704f4d
Modify the test code.
xsShuang 0d32357
Improvement of processing span code and test case information
xsShuang 47eb826
Modify the test code.
xsShuang c77ba51
Merge branch 'apache:main' into main
xsShuang 4b772bf
Merge remote-tracking branch 'origin/main'
xsShuang b68aa80
Modify the test code.
xsShuang 62884f5
Merge remote-tracking branch 'origin/main'
xsShuang c05c8f8
update skywalking-solon-2.x-scenario pom.xml
xsShuang 05bc9e5
Modify the test code.
xsShuang ae6c7cf
Merge pull request #1 from xsShuang/dev
xsShuang d253974
modify def file
xsShuang 20a3507
Merge pull request #2 from xsShuang/dev
xsShuang 2b72e14
update solon plugin
xsShuang 8fcb404
Modify the test code.
xsShuang a8cb8c3
Modify the test code.
xsShuang f6ffd0e
Merge pull request #3 from xsShuang/dev
xsShuang 3ace531
Add plugin configuration and instructions
xsShuang 53b9c5a
Add plugin configuration and instructions
xsShuang ca6ff8b
Modify the test code.
xsShuang c205c1a
Merge pull request #4 from xsShuang/dev
xsShuang 4b5e558
Add plugin configuration and instructions
xsShuang 5fbdc2a
Merge pull request #5 from xsShuang/dev
xsShuang 4982488
Add plugin configuration and instructions
xsShuang 916dc21
Merge pull request #6 from xsShuang/dev
xsShuang 505e99c
Modified to V2 version of the interceptor
xsShuang 115727f
Modified to V2 version of the interceptor
xsShuang 24799a6
Modified to V2 version of the interceptor
xsShuang 22a4a8f
Merge pull request #7 from xsShuang/dev
xsShuang 3524717
Modified to V2 version of the interceptor
xsShuang 160668c
Remove the code that collects all headers by default
xsShuang 08bdfcb
Merge pull request #8 from xsShuang/dev
xsShuang 38cb7b1
Optimised code
xsShuang 193b532
Modify the test code.
xsShuang 20c3545
Modify the test code.
xsShuang 9f3392e
Merge pull request #9 from xsShuang/dev
xsShuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?xml version="1.0"?> | ||
| <!-- | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one or more | ||
| ~ contributor license agreements. See the NOTICE file distributed with | ||
| ~ this work for additional information regarding copyright ownership. | ||
| ~ The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| ~ (the "License"); you may not use this file except in compliance with | ||
| ~ the License. You may obtain a copy of the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, software | ||
| ~ distributed under the License is distributed on an "AS IS" BASIS, | ||
| ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| ~ See the License for the specific language governing permissions and | ||
| ~ limitations under the License. | ||
| ~ | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <artifactId>apm-sdk-plugin</artifactId> | ||
| <groupId>org.apache.skywalking</groupId> | ||
| <version>9.3.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>solon-2.x-plugin</artifactId> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <name>solon-2.x-plugin</name> | ||
| <url>http://maven.apache.org</url> | ||
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <apache-httpclient.version>4.3</apache-httpclient.version> | ||
| <junit.version>4.12</junit.version> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.noear</groupId> | ||
| <artifactId>solon-lib</artifactId> | ||
| <version>2.8.3</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
104 changes: 104 additions & 0 deletions
104
...n/src/main/java/org/apache/skywalking/apm/plugin/solon/SolonActionExecuteInterceptor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.skywalking.apm.plugin.solon; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.apache.skywalking.apm.agent.core.context.CarrierItem; | ||
| import org.apache.skywalking.apm.agent.core.context.ContextCarrier; | ||
| import org.apache.skywalking.apm.agent.core.context.ContextManager; | ||
| import org.apache.skywalking.apm.agent.core.context.tag.Tags; | ||
| import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; | ||
| import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.InstanceMethodsAroundInterceptorV2; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.MethodInvocationContext; | ||
| import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; | ||
| import org.apache.skywalking.apm.util.StringUtil; | ||
| import org.noear.solon.core.NvMap; | ||
| import org.noear.solon.core.handle.Context; | ||
|
|
||
| import java.lang.reflect.Method; | ||
|
|
||
| @Slf4j | ||
| public class SolonActionExecuteInterceptor implements InstanceMethodsAroundInterceptorV2 { | ||
|
|
||
| @Override | ||
| public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, MethodInvocationContext context) throws Throwable { | ||
| Context ctx = (Context) allArguments[0]; | ||
| ContextCarrier contextCarrier = new ContextCarrier(); | ||
| CarrierItem next = contextCarrier.items(); | ||
| while (next.hasNext()) { | ||
| next = next.next(); | ||
| next.setHeadValue(ctx.header(next.getHeadKey())); | ||
| } | ||
| String operationName = ctx.method() + ":" + ctx.path(); | ||
| AbstractSpan span = ContextManager.createEntrySpan(operationName, contextCarrier); | ||
| span.setComponent(ComponentsDefine.SOLON_MVC); | ||
wu-sheng marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| SpanLayer.asHttp(span); | ||
| Tags.URL.set(span, ctx.url()); | ||
| Tags.HTTP.METHOD.set(span, ctx.method()); | ||
| if (SolonPluginConfig.Plugin.Solon.INCLUDE_HTTP_HEADERS != null && !SolonPluginConfig.Plugin.Solon.INCLUDE_HTTP_HEADERS.isEmpty()) { | ||
| NvMap includeHeaders = new NvMap(); | ||
| for (String header : SolonPluginConfig.Plugin.Solon.INCLUDE_HTTP_HEADERS) { | ||
| String value = ctx.header(header); | ||
| if (StringUtil.isNotBlank(value)) { | ||
| includeHeaders.put(header, value); | ||
| } | ||
| } | ||
| Tags.HTTP.HEADERS.set(span, includeHeaders.toString()); | ||
| } | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD != 0) { | ||
| String body = ctx.body(); | ||
| if (StringUtil.isNotBlank(body)) { | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD > 0 && body.length() > SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD) { | ||
| body = body.substring(0, SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD); | ||
| } | ||
| Tags.HTTP.BODY.set(span, body); | ||
| } | ||
| } | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD != 0) { | ||
| String param = ctx.paramMap().toString(); | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD > 0 && param.length() > SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD) { | ||
| param = param.substring(0, SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD); | ||
| } | ||
| Tags.HTTP.PARAMS.set(span, param); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, Object ret, MethodInvocationContext context) { | ||
| Context ctx = (Context) allArguments[0]; | ||
| Tags.HTTP_RESPONSE_STATUS_CODE.set(ContextManager.activeSpan(), ctx.status()); | ||
wu-sheng marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (ctx.errors != null && context.getContext() == null) { | ||
| AbstractSpan activeSpan = ContextManager.activeSpan(); | ||
| activeSpan.errorOccurred(); | ||
| activeSpan.log(ctx.errors); | ||
| } | ||
| ContextManager.stopSpan(); | ||
| return ret; | ||
| } | ||
|
|
||
| @Override | ||
| public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, Throwable t, MethodInvocationContext context) { | ||
| AbstractSpan activeSpan = ContextManager.activeSpan(); | ||
| activeSpan.errorOccurred(); | ||
| activeSpan.log(t); | ||
| context.setContext(true); | ||
| } | ||
| } | ||
43 changes: 43 additions & 0 deletions
43
...on-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/solon/SolonPluginConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.skywalking.apm.plugin.solon; | ||
|
|
||
| import org.apache.skywalking.apm.agent.core.boot.PluginConfig; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public class SolonPluginConfig { | ||
| public static class Plugin { | ||
| @PluginConfig(root = SolonPluginConfig.class) | ||
| public static class Solon { | ||
| /** | ||
| * Define the max length of collected HTTP parameters. The default value(=0) means not collecting. | ||
| */ | ||
| public static int HTTP_PARAMS_LENGTH_THRESHOLD = 0; | ||
| /** | ||
| * Define the max length of collected HTTP body. The default value(=0) means not collecting. | ||
| */ | ||
| public static int HTTP_BODY_LENGTH_THRESHOLD = 0; | ||
| /** | ||
| * It controls what header data should be collected, values must be in lower case, if empty, no header data will be collected. default is empty. | ||
| */ | ||
| public static List<String> INCLUDE_HTTP_HEADERS ; | ||
| } | ||
| } | ||
| } |
66 changes: 66 additions & 0 deletions
66
...c/main/java/org/apache/skywalking/apm/plugin/solon/define/SolonActionInstrumentation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.skywalking.apm.plugin.solon.define; | ||
|
|
||
| import net.bytebuddy.description.method.MethodDescription; | ||
| import net.bytebuddy.matcher.ElementMatcher; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.ClassInstanceMethodsEnhancePluginDefineV2; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.v2.InstanceMethodsInterceptV2Point; | ||
| import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch; | ||
| import org.apache.skywalking.apm.agent.core.plugin.match.NameMatch; | ||
|
|
||
| import static net.bytebuddy.matcher.ElementMatchers.named; | ||
|
|
||
| public class SolonActionInstrumentation extends ClassInstanceMethodsEnhancePluginDefineV2 { | ||
|
|
||
| private static final String INTERCEPT_CLASS = "org.apache.skywalking.apm.plugin.solon.SolonActionExecuteInterceptor"; | ||
|
|
||
| @Override | ||
| public ClassMatch enhanceClass() { | ||
| return NameMatch.byName("org.noear.solon.SolonApp"); | ||
| } | ||
|
|
||
| @Override | ||
| public ConstructorInterceptPoint[] getConstructorsInterceptPoints() { | ||
| return new ConstructorInterceptPoint[0]; | ||
| } | ||
|
|
||
| @Override | ||
| public InstanceMethodsInterceptV2Point[] getInstanceMethodsInterceptV2Points() { | ||
| return new InstanceMethodsInterceptV2Point[] { | ||
| new InstanceMethodsInterceptV2Point() { | ||
| @Override | ||
| public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
| return named("tryHandle"); | ||
| } | ||
|
|
||
| @Override | ||
| public String getMethodsInterceptorV2() { | ||
| return INTERCEPT_CLASS; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isOverrideArgs() { | ||
| return true; | ||
| } | ||
| } | ||
| }; | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
apm-sniffer/apm-sdk-plugin/solon-2.x-plugin/src/main/resources/skywalking-plugin.def
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| solon-2.x=org.apache.skywalking.apm.plugin.solon.define.SolonActionInstrumentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -177,3 +177,4 @@ | |
| - spring-webflux-6.x-webclient | ||
| - activemq-artemis-jakarta-client-2.x | ||
| - c3p0-0.9.x | ||
| - solon-2.x | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.