Skip to content

Add support for dameng(DM) JDBC URL format in URLParser#758

Merged
wu-sheng merged 8 commits into
apache:mainfrom
saber-wang:main
Jun 10, 2025
Merged

Add support for dameng(DM) JDBC URL format in URLParser#758
wu-sheng merged 8 commits into
apache:mainfrom
saber-wang:main

Conversation

@saber-wang

@saber-wang saber-wang commented Jun 9, 2025

Copy link
Copy Markdown
Contributor
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added the plugin label Jun 9, 2025
@wu-sheng

wu-sheng commented Jun 9, 2025

Copy link
Copy Markdown
Member

I think that although you added this parser, the DB connection must be managed by supported JDBC pooling. Right?

@saber-wang

Copy link
Copy Markdown
Contributor Author

I think that although you added this parser, the DB connection must be managed by supported JDBC pooling. Right?

Yes, because this is a standard JDBC driver, so using something like HikariCP is absolutely fine.

@wu-sheng

wu-sheng commented Jun 9, 2025

Copy link
Copy Markdown
Member

I don mean removing from doc. I mean in other PR, you could see there is a PR in UI repo.
For this, we would require that.

@saber-wang

Copy link
Copy Markdown
Contributor Author

@wu-sheng
I'm sorry, I've gone through the related PR and guidelines once more, but I'm still not entirely clear on what UI this is referring to.

Comment thread docs/en/setup/service-agent/java-agent/Supported-list.md Outdated
@wu-sheng

wu-sheng commented Jun 9, 2025

Copy link
Copy Markdown
Member

I mean you don't need this. https://github.com/apache/skywalking-booster-ui/pull/403/files

@saber-wang

Copy link
Copy Markdown
Contributor Author

Thanks a lot for the help 🙏!

Comment thread CHANGES.md Outdated
@wu-sheng wu-sheng changed the title Add support for dameng(DM) jdbc url format in URLParser Add support for dameng(DM) JDBC url format in URLParser Jun 10, 2025
@wu-sheng wu-sheng changed the title Add support for dameng(DM) JDBC url format in URLParser Add support for dameng(DM) JDBC URL format in URLParser Jun 10, 2025
@wu-sheng wu-sheng merged commit 6c74815 into apache:main Jun 10, 2025
207 of 258 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants