[Bug] Success Rate is Incorrect with Vert.x

[LangInteger]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

OAP server (apache/skywalking)

What happened

The success rate is incorrect when Skywalking is working with a Vert.x web server.

This demo project contains two APIs:

• 127.0.0.1:8081/success responds with HTTP code 200
• 127.0.0.1:8081/fail responds with HTTP code 500

In the dashboard, the success rate for both is 100%.

2 Reproduce

2.1 Start ES/OAP/UI/Vert.x_Web_Server

Using the following command:

wget -nc https://dlcdn.apache.org/skywalking/java-agent/9.1.0/apache-skywalking-java-agent-9.1.0.tgz &&
tar xzvf ./apache-skywalking-java-agent-9.1.0.tgz &&
./gradlew clean build && \
docker-compose build && \
export OAP_IMAGE=apache/skywalking-oap-server:9.7.0 && \
export UI_IMAGE=apache/skywalking-ui:9.7.0 && \
export ES_VERSION=7.10.2 && \
docker-compose up

What you expected to happen

The success rate for the fail API should be 0 as it responds with HTTP code 500.

How to reproduce

• Download the demo project: https://github.com/LangInteger/vertx-skywalking
• Follow the Reproduce section in the README.md file

Anything else

Please kindly let me know if it is not a bug and I can correct it with some settings. Thanks!

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

Success rate and traffic is calculated based on entry spans from your traces. Please check there.

[LangInteger]

Hi Sheng, it seems like Brandon is not actively responding currently.
I would appreciate your letting me know where the plugin-related code is stored.
I cannot find these code now:

• Vert.x Core 3.x Plugin #2386

[wu-sheng]

It is Christmas vacations, he should not be on Github.

The codes in the same place, but in this new repo, https://github.com/apache/skywalking-java

[LangInteger]

@wu-sheng Thank you! I will look at this when I have time.

[BFergerson]

Apologies for the wait. Please check: apache/skywalking-java#662

[LangInteger]

@BFergerson Hi, Brandon, do you have any insights on this case?