[SPARK-55408][PS] Handle unexpected keyword argument errors related to datetime with pandas 3#54191
Open
ueshin wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55408][PS] Handle unexpected keyword argument errors related to datetime with pandas 3#54191ueshin wants to merge 2 commits intoapache:masterfrom
ueshin wants to merge 2 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Sub-task SPARK-55408 === This comment was automatically generated by GitHub Actions |
Member
Author
ueshin
changed the title
| kwargs["closed"] = closed | ||
| else: | ||
| if normalize is not _NoValue: | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
I don't remember how we deal with other removed arguments, but unexpected keyword argument should probably raise a TypeError (I think pandas does it too, well it's probably Python that does the job).
gaogaotiantian
approved these changes
Feb 7, 2026
zhengruifeng
approved these changes
Feb 7, 2026
dongjoon-hyun
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Handles an unexpected keyword argument error related to datetime with pandas 3.
Why are the changes needed?
There are removed arguments in datetime-related functions.
DatetimeIndex:normalize,closedto_datetime:infer_datetime_formatDoes this PR introduce any user-facing change?
Yes, it will behave more like pandas 3.
How was this patch tested?
Updated a related test and the other existing tests should pass.
Was this patch authored or co-authored using generative AI tooling?
No.