Merged
Conversation
qinkunbao
previously approved these changes
Dec 14, 2021
Member
qinkunbao
left a comment
There was a problem hiding this comment.
Thank you for this PR. When compiling in incremental mode, Teaclave compiled some unnecessary crates and libraries. This PR fixes the bug in the dependency and decreases the building time significantly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fix building issue.
According to rust-lang/cargo#2904, I enabled cargo log with
CARGO_LOG=cargo::core::compiler::fingerprint=traceand see this log:I realize that this additional
test_modeflag affect the rebuild. However, when building withTEST_MODE=ON, thetest_modeflag has been added to all services. Therefore, we can safely delete this.Type of change (select or add applied and delete the others)
How has this been tested?
CI.
Checklist
master.