Skip to content

Fix privilege issue#636

Merged
mssun merged 3 commits intoapache:masterfrom
mssun:fix-privilege-issue
Mar 18, 2022
Merged

Fix privilege issue#636
mssun merged 3 commits intoapache:masterfrom
mssun:fix-privilege-issue

Conversation

@mssun
Copy link
Member

@mssun mssun commented Mar 18, 2022

Description

Fix privilege issues.

  • fix inconsistency of GetFunction and ListFunctions interfaces
  • add GetKeysByPrefix interface to the storage service to help the fix

Fixes #624

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New interface

How has this been tested?

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

Copy link
Contributor

@AI-Memory AI-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1, thanks.

@mssun mssun merged commit 22eb01b into apache:master Mar 18, 2022
@mssun mssun deleted the fix-privilege-issue branch March 18, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

list_functions and get_function have different access controls

2 participants