Skip to content

Fix docker build issue caused by missing dependency of tomli#686

Merged
henrysun007 merged 1 commit intoapache:masterfrom
sarutak:fix-build-docker-files
Apr 24, 2023
Merged

Fix docker build issue caused by missing dependency of tomli#686
henrysun007 merged 1 commit intoapache:masterfrom
sarutak:fix-build-docker-files

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Apr 22, 2023

Description

docker build for build.ubuntu-1804-sgx-2.17.1.Dockerfile and build.ubuntu-1804-sgx-dcap-1.14.Dockerfile fails due to missing dependency of tomli, a Python library.

$ docker build -t ubuntu-1804-sgx-2.17.1:latest . -f  docker/build.ubuntu-1804-sgx-dcap-1.14.Dockerfile
  Could not find a version that satisfies the requirement tomli>=2.0.1 (from yapf) (from versions: 0.2.0, 0.2.1, 0.2.2, 0.2.3, 0.2.4, 0.2.5, 0.2.6, 0.2.7, 0.2.8, 0.2.9, 0.2.10, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.2.0, 1.2.1, 1.2.2, 1.2.3)
No matching distribution found for tomli>=2.0.1 (from yapf)
The command '/bin/sh -c pip3 install pyopenssl==21.0.0 toml cryptography yapf requests Pillow' returned a non-zero code: 1

I confirmed this issue doesn't happen with build.ubuntu-2004-sgx-2.17.1.Dockerfile or build.ubuntu-2004-sgx-dcap-1.14.Dockerfile.

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just sync with upstream third-party crates

How has this been tested?

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@sarutak sarutak changed the title Fix build docker files. Fix docker build issue caused by lack of tomli Apr 22, 2023
@sarutak sarutak changed the title Fix docker build issue caused by lack of tomli Fix docker build issue caused by missing dependency of tomli Apr 22, 2023
@mssun mssun self-requested a review April 22, 2023 21:21
Copy link
Member

@mssun mssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@henrysun007 henrysun007 merged commit e2c6e31 into apache:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants