[microNPU] Refactor type inference data type checks#10060
Merged
manupak merged 3 commits intoapache:mainfrom Feb 9, 2022
Merged
[microNPU] Refactor type inference data type checks#10060manupak merged 3 commits intoapache:mainfrom
manupak merged 3 commits intoapache:mainfrom
Conversation
lhutton1
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
lhutton1
force-pushed
the
refactor-infer-dtype-checks
branch
from
a366433 to
752a4c0
Compare
Contributor
|
Other than the previous comments, LGTM! Thanks, @lhutton1 |
Aims to improve readability, extendibility and error message unification for data type checks across NPU operators. A follow up for the comments in apache#9576. Change-Id: I83fb89a56677003f7abebb7985ad60d92cfa8df1
Change-Id: Icf3d68d5cc7d5e1d5af42b1af193db89faea155e
lhutton1
force-pushed
the
refactor-infer-dtype-checks
branch
from
752a4c0 to
3536c4e
Compare
Change-Id: I10311b718c3abd0ed75dd88b5ec9de6e0742f047
lhutton1
force-pushed
the
refactor-infer-dtype-checks
branch
from
f80bc3f to
86ac9c0
Compare
manupak
approved these changes
Feb 9, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
LGTM!.
@NicolaLancellotti can you take another look ?
Contributor
|
Thanks! @lhutton1 @NicolaLancellotti. This is merged now! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* [microNPU] Refactor type inference data type checks Aims to improve readability, extendibility and error message unification for data type checks across NPU operators. A follow up for the comments in apache#9576. Change-Id: I83fb89a56677003f7abebb7985ad60d92cfa8df1 * unordered_set -> initializer_list and use new format for upscale check Change-Id: Icf3d68d5cc7d5e1d5af42b1af193db89faea155e * remove unused header and use auto for initializer type Change-Id: I10311b718c3abd0ed75dd88b5ec9de6e0742f047
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to improve readability, extensibility and error message unification for data type checks across NPU operators.
A follow up for the comments in #9576.
cc @ekalda @manupa-arm @NicolaLancellotti @mbaret @dchauhan-arm @jacobbohlin