[TIR][Schedule] Update compact_dataflow constraint#10158
Merged
junrushao merged 2 commits intoapache:mainfrom Feb 3, 2022
Merged
[TIR][Schedule] Update compact_dataflow constraint#10158junrushao merged 2 commits intoapache:mainfrom
junrushao merged 2 commits intoapache:mainfrom
Conversation
Hzfengsy
requested review from
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
junrushao
approved these changes
Feb 3, 2022
mbs-octoml
pushed a commit
to mbs-octoml/mbs-tvm
that referenced
this pull request
Feb 5, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compact_dataflowis a very strong constraint, which requires all the blocks in the sub-AST to be complete or reduction blocks. Currently, there are two primitives that use such property:However, requiring all the scope to be
compact_dataflowis too strict that some correct transformations are banned. (please see the added test cases). Here I updated the requirements:cc @spectrometerHBH @junrushao1994 @vinx13