[TRT] Remove depreceated intergration tests with mxnet zoo importers#10772
Merged
masahi merged 1 commit intoapache:mainfrom Mar 25, 2022
Merged
[TRT] Remove depreceated intergration tests with mxnet zoo importers#10772masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
mikepapadim
changed the title
masahi
approved these changes
Mar 25, 2022
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
I recommend using PyTorch if you want to do e2e tests. Many models are available from torchvision, including quantized ones. PT is installed in the gpu image so it is readily available.
Contributor
Author
+1 for adding these. However, I think it will add a significant t on CI cicles. |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…che#10772) Co-authored-by: Michalis Papapdimitriou <mpapapdimitriou@octoml.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, under
test_tensorrt.pythere is a mixture of integration and unit tests.Integration tests (e.g., from mxnet zoo ) are deprecated and failing since #8901.
This PR removed integrations tests from the pytest runner.
If required, a follow-up PR can introduce integration tests from onnx, however, can increase CI overhead.
@mbaret @mbs-octoml @masahi