[Arith] Remove diagnostic ctx argument from DetectIterMap#10798
Merged
junrushao merged 1 commit intoapache:mainfrom Mar 28, 2022
Merged
[Arith] Remove diagnostic ctx argument from DetectIterMap#10798junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
junrushao
approved these changes
Mar 28, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
@wrongtest Thanks for doing this :-)
While it's ideal decoupling frontend and analysis features as what's being done in this PR, we definitely as well would love to improve error reporting in this particular case. Would love to hear more ideas from @spectrometerHBH @Hzfengsy
junrushao
changed the title
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.