Move WrapTimeEvaluator from RPC to profiling, NFC#11172
Merged
masahi merged 1 commit intoapache:mainfrom Apr 29, 2022
kparzysz-quic:profiling-move
Merged
Move WrapTimeEvaluator from RPC to profiling, NFC#11172masahi merged 1 commit intoapache:mainfrom kparzysz-quic:profiling-move
masahi merged 1 commit intoapache:mainfrom
kparzysz-quic:profiling-move
Conversation
Contributor
Author
|
Having this function in RPC caused a problem when building apps/hexagon_launcher. The RPC code is not built for Hexagon, but graph executor and profiling support is, and we ended up with Profiling seems like a better place for this function anyway, since it has to do with time measurements, and has nothing to do with RPC. |
masahi
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.