Add unidirectional sequence lstm#11183
Conversation
|
All tests passed |
|
Now this fails on windows. I restarted the CI pipeline three times. Does not seem to be related to our changes. Should or could we do anything to resolve this? |
|
@SebastianBoblestETAS I think this is effecting more than just this PR, I've raised #11220 to track it, please stand by 😸 |
|
@Mousius Hi, sorry this is again failing but in a totally different place now. |
|
There is still the issue of the model we use in the tests. |
|
@SebastianBoblestETAS I re-ran the CI yesterday and it looks green, though I don't really know that much about this PR other than the CI issues - maybe @leandron can help get this merged? 😸 |
|
@leandron Hi, could you maybe help with getting this merged? |
|
@junrushao1994 Hi, could you also have a look on our PR and help to make it merged? Thanks. |
|
@mbrookhart @jwfromm @Huyuwei @hlu1 @AndrewZhaoLuo @kazum @siju-samuel @srkreddy1238 @FrozenGene |
|
Ill take a look tomorrow |
@AndrewZhaoLuo did you review our PR? We are ready to answer your question. |
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
Sorry for getting back to you late. LGTM!
|
@Mousius We just add some comments as request from @AndrewZhaoLuo, but the tvm-ci failed again. Could you please support us to restart it? |
|
@vdkhoi you can restart CI by pushing an empty commit. e.g. |
|
@AndrewZhaoLuo I updated the comment in the function and made it more precise. |
|
Sometimes you also need to rebase on main to solve flaky CI issues :/ . Sorry about that |
…ding to the version in common.py
ccfbebd to
efecbcd
Compare
|
@AndrewZhaoLuo I just rebased. Let's hope for the best 😄 |
|
Thanks! Sorry this took a long time to get merged. |
Thank you. Finally :) it done |
This work has mostly been done by @vdkhoi Khoi Duy Vo from ETAS Gmbh.
We add parser support for UnidirectionalSequenceLSTM layers in tflite.
A question regarding the test:
At the moment it uses a toy model that I store in a repo in my github account.
Should we copy this to the TVM repo or what is the best way to do this?