[DNNL] Fix end of line in test_dnnl UT file#11560
Conversation
|
Hi @masahi, @AndrewZhaoLuo , Could you please review this change? |
|
Why do we need to fix this? |
|
If I understand this change correctly this is entirely style; git will handle different line deliminators fine, but the issue is that if a windows dev edits a file with LF, it will replace all lines with CRLF through the entire file which means every line will be changed in diffs. This will make the commit log a bit gummier. cc @areusch @driazati it seems like a good idea to force LF for new lines? can we lint for this. |
|
We should definitely check for this kind of thing in CI, opened #11609 |
|
Hi @masahi , @AndrewZhaoLuo , I hit this issue when I am trying to accomplish my another PR #11513 . It seems that somebody use windows as development environment and unexpectedly reformat the whole LF to CRLF. Git status command shows this change and it is annoying for other developer of tvm. To eliminate this issue, I propose this patch. |
37329fb to
c99b3d1
Compare
The end of line in test_dnnl.py is CRLF which is not identical to other python files. This patch is going to fix this by replacing CRLF to LF.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.