[MetaSchedule] Resolve dependencies between header files#11604
Merged
kparzysz-quic merged 2 commits intoapache:mainfrom Jun 7, 2022
kparzysz-quic:meta-scheduler-dependency
Merged
[MetaSchedule] Resolve dependencies between header files#11604kparzysz-quic merged 2 commits intoapache:mainfrom kparzysz-quic:meta-scheduler-dependency
kparzysz-quic merged 2 commits intoapache:mainfrom
kparzysz-quic:meta-scheduler-dependency
Conversation
After PR11590 TVM stopped compiling with clang-14 and libc++. The problems were caused by incomplete types used in contexts where complete types were required. To resolve this, some code had to be moved into .cc files. Also the MeasureCandidate classes needed to be added to their own include files (or otherwise there would be a circular dependency between headers). All headers from the meta_schedule directory were updated to include all their dependencies (forward declarations were left where appropriate).
junrushao
approved these changes
Jun 7, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Probably I overlooked some dependency issues. Thanks for the swift fix!
Member
|
Would you mind if I quickly send some commits in this PR if it’s blocking work from your org? |
Contributor
Author
|
Sure, go ahead. |
Contributor
Author
|
It's gone through CI, so I'm going to merge it. |
Member
|
Thanks @kparzysz-quic!! Sorry for the weird issues introduced by my previous PR! |
Kathryn-cat
pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
* [MetaSchedule] Resolve dependencies between header files After PR11590 TVM stopped compiling with clang-14 and libc++. The problems were caused by incomplete types used in contexts where complete types were required. To resolve this, some code had to be moved into .cc files. Also the MeasureCandidate classes needed to be added to their own include files (or otherwise there would be a circular dependency between headers). All headers from the meta_schedule directory were updated to include all their dependencies (forward declarations were left where appropriate). * Fix a typo: PySpaceGeneratorCode -> PySpaceGeneratorNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR11590 TVM stopped compiling with clang-14 and libc++. The problems were caused by incomplete types used in contexts where complete types were required. To resolve this, some code had to be moved into .cc files. Also the
MeasureCandidateclasses needed to be added to their own include files (or otherwise there would be a circular dependency between headers).All headers from the meta_schedule directory were updated to include all their dependencies (forward declarations were left where appropriate).