[MetaSchedule] Developer Ergonomics Enhancement#11622
Merged
junrushao merged 1 commit intoapache:mainfrom Jun 10, 2022
Merged
Conversation
1cc1563 to
6c2470d
Compare
Member
Author
|
To avoid the PR being overly huge, we decided to upstream the rest of the enhancement as a separate PR. |
Kathryn-cat
reviewed
Jun 9, 2022
Kathryn-cat
reviewed
Jun 9, 2022
zxybazh
approved these changes
Jun 9, 2022
Member
zxybazh
left a comment
There was a problem hiding this comment.
The changes makes a lot of sense to me and generally making it easier to access each function in the task. Generally looks good to me. A couple nits as mentioned in Kathryn's comments could further simplify the functions. It looks to me that SendtoBuilder and SendtoRunner could be further put into TuneContext level but let's leave that to the next PR. Thanks for the changes!
Kathryn-cat
reviewed
Jun 9, 2022
56a186d to
a3feda7
Compare
Per discussion with @Kathryn-cat - [x] Move `initialize_with_tune_context` as private API `_initialize_with_tune_context`, and encourage using `TuneContext.initialize` - [x] Instead of using bunch of import statements, encourage using `ms.xxx` as the prefix (e.g. `ms.database.MemoryDatabase`) to organize things better - [x] Move `DefaultLLVM`, `DefaultCUDA` to a separate file and make them more discoverable - [x] Move `DummyDatabase` to `tvm.meta_schedule.database.MemoryDatabase` given it's actually useful - [x] Delegate class members' methods in `TuneContext`, for example, having `TuneContext.generste_design_space` from `TuneContext.space_generator.generste_design_space` Next PR: - Allow using a string `"default"` in `TuneContext` as well as `tune_relay/tir/te` to quickly specify a set of target-specific rules - Add `TuneContext.tune` to allow directly tuning without task scheduler. - Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
a3feda7 to
e65f18e
Compare
Kathryn-cat
added a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
Per discussion with @Kathryn-cat - [x] Move `initialize_with_tune_context` as private API `_initialize_with_tune_context`, and encourage using `TuneContext.initialize` - [x] Instead of using bunch of import statements, encourage using `ms.xxx` as the prefix (e.g. `ms.database.MemoryDatabase`) to organize things better - [x] Move `DefaultLLVM`, `DefaultCUDA` to a separate file and make them more discoverable - [x] Move `DummyDatabase` to `tvm.meta_schedule.database.MemoryDatabase` given it's actually useful - [x] Delegate class members' methods in `TuneContext`, for example, having `TuneContext.generste_design_space` from `TuneContext.space_generator.generste_design_space` Next PR: - Allow using a string `"default"` in `TuneContext` as well as `tune_relay/tir/te` to quickly specify a set of target-specific rules - Add `TuneContext.tune` to allow directly tuning without task scheduler. - Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jun 15, 2022
Follow-up of apache#11622, per discussion with @Kathryn-cat - [x] Allow using a string `"default"` in `TuneContext` to quickly specify a set of target-specific rules - [x] Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Next PR: - Add `TuneContext.tune` to allow directly tuning without task scheduler. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
2 tasks
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jun 15, 2022
Follow-up of apache#11622, per discussion with @Kathryn-cat - [x] Allow using a string `"default"` in `TuneContext` to quickly specify a set of target-specific rules - [x] Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Next PR: - Add `TuneContext.tune` to allow directly tuning without task scheduler. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jun 15, 2022
Follow-up of apache#11622, per discussion with @Kathryn-cat - [x] Allow using a string `"default"` in `TuneContext` to quickly specify a set of target-specific rules - [x] Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Next PR: - Add `TuneContext.tune` to allow directly tuning without task scheduler. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jun 15, 2022
Follow-up of apache#11622, per discussion with @Kathryn-cat - [x] Allow using a string `"default"` in `TuneContext` to quickly specify a set of target-specific rules - [x] Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Next PR: - Add `TuneContext.tune` to allow directly tuning without task scheduler. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
junrushao
added a commit
that referenced
this pull request
Jun 15, 2022
Follow-up of #11622, per discussion with @Kathryn-cat - [x] Allow using a string `"default"` in `TuneContext` to quickly specify a set of target-specific rules - [x] Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Next PR: - Add `TuneContext.tune` to allow directly tuning without task scheduler. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion with @Kathryn-cat:
TuneContext.initialize, and movinginitialize_with_tune_contextas privateAPI
_initialize_with_tune_context;ms.xxxas the prefix (e.g.ms.database.MemoryDatabase) to organize codebetter, instead of using multiple import statements;
ms.default_config.xxx(e.g.schedule_rule);tvm.meta_schedule.testing.DummyDatabasetotvm.meta_schedule.database.MemoryDatabasegiven it's actually functioning;
TuneContext, for example, havingTuneContext.generste_design_spacefromTuneContext.space_generator.generste_design_spaceNext PR:
"default"inTuneContextas well astune_relay/tir/teto quicklyspecify a set of target-specific rules
TuneContext.tuneto allow directly tuning without task scheduler.ScheduleFninTuneContextto make it easier for users to quickly try outtemplate-driven scheduling on TIR.