[Relay] Finish implementations of WithFields#11674
Merged
Mousius merged 5 commits intoapache:mainfrom Jun 11, 2022
Merged
Conversation
Mousius
requested changes
Jun 11, 2022
Member
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
Yay! Consistency! Just needs a few more tests and this LGTM @mbs-octoml
This has been sitting in my collage branch forever, might as well clear it into main. I added the beginnings of a unit test, but only for the Call overload.
Contributor
Author
Contributor
Author
|
Thanks @Mousius, pls merge when you get a chance. |
mbs-octoml
force-pushed
the
mbs-collage-withfields
branch
from
716654b to
5c041fe
Compare
Mousius
approved these changes
Jun 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been sitting in my collage branch forever, might as well clear it into main.
I added the beginnings of a unit test, but only for the Call overload.