[LLVM] Include LLVM headers in files that use them, not in llvm_common.h#11888
Merged
junrushao merged 1 commit intoapache:mainfrom Jun 25, 2022
kparzysz-quic:llvm.2-common-includes
Merged
[LLVM] Include LLVM headers in files that use them, not in llvm_common.h#11888junrushao merged 1 commit intoapache:mainfrom kparzysz-quic:llvm.2-common-includes
junrushao merged 1 commit intoapache:mainfrom
kparzysz-quic:llvm.2-common-includes
Conversation
This is following the same principle we use everywhere else in TVM, that is, every source file includes headers that it depends on. While including unnecessary LLVM headers (which may happen by including llvm_common.h) is not actively harmful, it makes the header dependencies much less trans- parent.
kparzysz-quic
requested review from
Lunderberg,
areusch and
mehrdadh
and removed request for
Lunderberg and
mehrdadh
junrushao
approved these changes
Jun 25, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM. Usually there isnt much difference between the two approaches, but I agree it makes dependency looks more clear
zxybazh
pushed a commit
to zxybazh/tvm
that referenced
this pull request
Jun 26, 2022
…n.h (apache#11888) This is following the same principle we use everywhere else in TVM, that is, every source file includes headers that it depends on. While including unnecessary LLVM headers (which may happen by including llvm_common.h) is not actively harmful, it makes the header dependencies much less trans- parent.
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
…n.h (apache#11888) This is following the same principle we use everywhere else in TVM, that is, every source file includes headers that it depends on. While including unnecessary LLVM headers (which may happen by including llvm_common.h) is not actively harmful, it makes the header dependencies much less trans- parent.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…n.h (apache#11888) This is following the same principle we use everywhere else in TVM, that is, every source file includes headers that it depends on. While including unnecessary LLVM headers (which may happen by including llvm_common.h) is not actively harmful, it makes the header dependencies much less trans- parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is following the same principle we use everywhere else in TVM, that is, every source file includes headers that it depends on. While including unnecessary LLVM headers (which may happen by including llvm_common.h) is not actively harmful, it makes the header dependencies much less transparent.