Skip to content

[Metaschedule] EvolutionarySearchNode::State constructor typo fix#14002

Merged
Mousius merged 1 commit into
apache:mainfrom
Deelvin:sshtin/evolutionary_search_typo_fix
Feb 16, 2023
Merged

[Metaschedule] EvolutionarySearchNode::State constructor typo fix#14002
Mousius merged 1 commit into
apache:mainfrom
Deelvin:sshtin/evolutionary_search_typo_fix

Conversation

@shtinsa

@shtinsa shtinsa commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

This PR fixes internal object initialization in EvolutionarySearchNode::State class. Unfortunately there is no way to prepare test case.

@tvm-bot

tvm-bot commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@shtinsa shtinsa changed the title [Metaschedule] EvolutionarySearchNode::State constructor typo fix. [Metaschedule] EvolutionarySearchNode::State constructor typo fix Feb 15, 2023
@shtinsa

shtinsa commented Feb 15, 2023

Copy link
Copy Markdown
Contributor Author

@tvm-bot rerun

@Mousius Mousius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shtinsa ,

It looks like the CI is failing because your PR has no description, could you please add one as well as a test case to demonstrate the issue this fixes?

@shtinsa

shtinsa commented Feb 15, 2023

Copy link
Copy Markdown
Contributor Author

@tvm-bot rerun

@junrushao junrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shtinsa

shtinsa commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

Hi @shtinsa ,

It looks like the CI is failing because your PR has no description, could you please add one as well as a test case to demonstrate the issue this fixes?

Unfortunately it is a problem to create test.

@junrushao

junrushao commented Feb 16, 2023

Copy link
Copy Markdown
Member

To be clear, this is not possible to create a test, as the code itself is a type, rather than a bug that leads to segfault or exceptions

@Mousius

Mousius commented Feb 16, 2023

Copy link
Copy Markdown
Member

@shtinsa / @junrushao - I've tested similar things in the past, as far as I can see this is simply ensuring a more precise allocation which should be testable. Alas, TVM does not have good testing practices so I don't think there's an easy way forward. Thanks for the contribution @shtinsa, hope it doesn't unfix itself in future 😸

@Mousius Mousius merged commit aa927df into apache:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants