[Bugfix][Relay][Keras] Fix SeparableConv2D conversion in dilation_rate attribute#15122
Merged
masahi merged 3 commits intoapache:mainfrom Jun 21, 2023
jikechao:fix_SeparableConv2D
Merged
[Bugfix][Relay][Keras] Fix SeparableConv2D conversion in dilation_rate attribute#15122masahi merged 3 commits intoapache:mainfrom jikechao:fix_SeparableConv2D
masahi merged 3 commits intoapache:mainfrom
jikechao:fix_SeparableConv2D
Conversation
fix the _convert_separable_convolution. The dilation_rate always be the default value (e.g., [1,1]).
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
echuraev
approved these changes
Jun 20, 2023
Contributor
echuraev
left a comment
There was a problem hiding this comment.
Thanks for your PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed a bug about
dilation_ratein SeparableConv2D.The attribute
dilation_rateabout SeparableConv2D layer has the following constraints in Keras documentation:TVM always considered the
dilation_rateas a default value. This will lead to wrong calculation results.This PR fix this bug and added the bug-triggering test cases.
Steps to reproduce
cc @Hzfengsy @echuraev @leandron