[microNPU][ETHOSU] Fix compiler attributes types#15159
Merged
lhutton1 merged 4 commits intoapache:mainfrom Jun 29, 2023
Merged
Conversation
Collaborator
lhutton1
reviewed
Jun 26, 2023
Contributor
lhutton1
left a comment
There was a problem hiding this comment.
Thanks for the fix @Aleksei-grovety, is it possible to add some tests?
lhutton1
reviewed
Jun 28, 2023
Contributor
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @Aleksei-grovety, LGTM! It looks like this got conflicted with #15147, so it'll need a quick rebase first :)
The bool type is replaced with tvm::Bool to pass these parameters to tvmc via the command line.
fba84f9 to
70f60ef
Compare
70f60ef to
72302df
Compare
lhutton1
approved these changes
Jun 29, 2023
Contributor
|
Thanks @Aleksei-grovety! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bool type is replaced with tvm::Bool to pass these parameters to tvmc via the command line.
cc @neildhickey, @lhutton1, @ekalda, @leandron