[Frontend][Relay][Keras] Fix concatenate convert function in axis parsing#15175
Merged
tqchen merged 16 commits intoapache:mainfrom Jul 1, 2023
jikechao:fix_concatenate
Merged
[Frontend][Relay][Keras] Fix concatenate convert function in axis parsing#15175tqchen merged 16 commits intoapache:mainfrom jikechao:fix_concatenate
tqchen merged 16 commits intoapache:mainfrom
jikechao:fix_concatenate
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
junrushao
approved these changes
Jun 28, 2023
Member
Author
|
The newly added test cases cannot pass the CI test. However, It can run well in my local environment. So wired it is. |
Member
|
Is it related to the Karas version? |
Member
Author
|
@Hzfengsy @junrushao Thanks for your comments and review. |
Member
Author
|
@echuraev Thanks for your review. |
Member
Author
|
@tvm-bot rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixed the bug in #15174 and added some specific test cases for Concatenate operator.
cc @echuraev @Hzfengsy