[CMAKE] Conditionally link "clog" in NNPack install#15359
Merged
asparkhi merged 1 commit intoapache:mainfrom Jul 20, 2023
Merged
[CMAKE] Conditionally link "clog" in NNPack install#15359asparkhi merged 1 commit intoapache:mainfrom
asparkhi merged 1 commit intoapache:mainfrom
Conversation
"cpuinfo" is a direct dependency of NNPack. It is installed via the NNPack's cmake script, but the version is not pinned. The "clog" dependency was recently removed from "cpuinfo" (pytorch/cpuinfo@3dc3103), which leads to issues when compiling TVM with support for NNPack. When building TVM with newly generated docker images and NNPack enabled, we run into the following cmake configuration error: ``` The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: NNPACK_CLOG_CONTRIB_LIB ``` This commit intends to fix this failure while also keeping compatibility with older versions of cpuinfo. It conditionally adds "clog" to the linker libs variable if it was found. Change-Id: I103f81b7ac75e9623ed808d240ce959749c13cf2
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
cchung100m
approved these changes
Jul 20, 2023
Contributor
cchung100m
left a comment
cchung100m
left a comment
There was a problem hiding this comment.
LGTM, thanks to @lhutton1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"cpuinfo" is a direct dependency of NNPack. It is installed via the NNPack's cmake script, but the version is not pinned. The "clog" dependency was recently removed from "cpuinfo"
(pytorch/cpuinfo@3dc3103), which leads to issues when compiling TVM with support for NNPack.
When building TVM with newly generated docker images and NNPack enabled, we run into the following cmake configuration error:
This commit intends to fix this failure while also keeping compatibility with older versions of cpuinfo. It conditionally adds "clog" to the linker libs variable if it was found.