Do not link LLVM libraries into cpptest binary#15639
Merged
Hzfengsy merged 1 commit intoapache:mainfrom Aug 30, 2023
Merged
Conversation
junrushao
approved these changes
Aug 28, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Looks great! Thanks for fixing this issue!
kparzysz-quic
force-pushed
the
cpptest-link-llvm
branch
from
a76334b to
12694b0
Compare
… TVM They are already linked into libtvm.so, and cpptests links against libtvm.so, so if they are visible in the TVM library, they are not needed again. On the other hand, linking them twice can lead to the following error: ``` CommandLine Error: Option 'print-summary-global-ids' registered more than once! LLVM ERROR: inconsistency in registered CommandLine options ```
kparzysz-quic
force-pushed
the
cpptest-link-llvm
branch
from
12694b0 to
68d2759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are already linked into libtvm.so, and cpptests links against libtvm.so, so they are not needed again. On the other hand, linking them twice can lead to the following error: