[TOPI][ADRENO] Add conv2d transpose nchw texture schedule #15786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the conv2d transpose strategy for adreno target and enable the optimized schedule.
krishnaraj36
changed the title
Contributor
Author
|
@srkreddy1238 : Please review the PR |
Contributor
Author
|
@srkreddy1238 : Please review |
tests/python/relay/opencl_texture/test_conv2d_transpose_nchw_texture.py
Outdated
Show resolved
Hide resolved
tests/python/relay/opencl_texture/test_conv2d_transpose_nchw_texture.py
Outdated
Show resolved
Hide resolved
Contributor
|
Over all LGTM. Few comments above. |
echuraev
reviewed
Oct 11, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Thank you for your PR. Some of my comments:
It is failing for few gpu devices.
srkreddy1238
requested changes
Nov 4, 2023
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
Almost good to go except couple of tests.
tests/python/relay/opencl_texture/test_conv2d_transpose_nchw_texture.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@echuraev : Please review and if all looks good, please approve the PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the conv2d transpose strategy for adreno target and enable the optimized schedule.