[ONNX] Fix interpreting auto_pad parameters in ConvTranspose operator#16001
Conversation
|
@tvm-bot rerun |
378f598 to
89373d8
Compare
|
Hello, looks like that the problem with this PRs failure is due to the different implementations of convTranspose operator in different versions of onnxruntime. Precissely, onnxruntime 1.12 and 1.15 gives different results when the parameters SAME_UPPER and SAME_LOWER are used. On my local machine, this tests passes when onnxruntime 1.15 is used, and fail with 1.12 (probably due to wrong implementation), although the operator is implemented according to ONNX documentation. What could be the next step for this PR? What is the common practice here: Sorry if I tagged someone not related to the topic. |
89373d8 to
d63098a
Compare
|
Hello, looks like this PR is staying opened this way for quite some time now. Any feedback related to this PR? |
…WER in ConvTranspose operator
d63098a to
9de8714
Compare
|
Hello, Any updates on this one? Can we get this merged as it has been approved for quite some time now, and is passing all the tests? |
|
@padreofthegame it was merged! Thanks for the fix! |
Fix in interpreting auto_pad parameters SAME_UPPER and SAME_LOWER in ConvTranspose version 1 and 11 operator according to documentation on link.
Tests that were failing are also added in test_forward.py.
Also, enable unsupported test for ONNX: test_convtranspose_autopad_same.