Skip to content

Conversation

@PhilippvK
Copy link
Contributor

Converting work_dir = tvm.contrib.utils.tempdir() to str yields "<tvm.contrib.utils.TempDirectory object at 0x7fc5322c3790>/" which creates a so-called file in the current working directory.

This change uses str(work_dir.path) instead, resulting in the expected behavior.

…edule, NFC

Converting `work_dir = tvm.contrib.utils.tempdir()` to `str` yields `"<tvm.contrib.utils.TempDirectory object at 0x7fc5322c3790>/"` which creates a so-called file in the current working directory.

This change uses `str(work_dir.path)` instead, resulting in the expected behavior.
Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@tqchen tqchen merged commit ba0179f into apache:main Oct 31, 2023
@PhilippvK PhilippvK deleted the fix-ms-unittest-tempdir branch January 23, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants